Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show sequences at 100% progress #1049

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Don't show sequences at 100% progress #1049

merged 1 commit into from
Jul 30, 2021

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Jul 29, 2021

Closes #1044, Reopens #1030

#1031 was a mistake, and it lead to bad behavior.

  • I have added additional features that should now be part of the PR template. I made the necessary changes to the template.
  • I have fixed a bug/the added functionality should not be part of the PR template.
    • I added a test/ tests.
  • I have run all our tests and they still work.

@frcroth frcroth merged commit 999b60c into dev Jul 30, 2021
@frcroth frcroth deleted the fix/dont-show-sequences-at-100-percent-progress branch July 30, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paula-Kli Paula-Kli Paula-Kli approved these changes

@linusha linusha linusha approved these changes

@SilvanVerhoeven SilvanVerhoeven Awaiting requested review from SilvanVerhoeven

@T4rikA T4rikA Awaiting requested review from T4rikA

Assignees

@frcroth frcroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequences overlap
3 participants
@frcroth @linusha @Paula-Kli