Fix GaLore 8-bit updates with ZeRO CPU offload - #6432
Open
sdjasj wants to merge 1 commit into
Open
Conversation
sdjasj
force-pushed
the
agent/fix-galore-cpu-offload-6399
branch
from
July 29, 2026 13:09
82b4cfa to
4a5ea63
Compare
sdjasj
marked this pull request as ready for review
August 1, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
bitsandbytes only provides GPU update kernels.
LowLevelZeroPlugin(cpu_offload=True)placed the master parameter, gradient, quantized states, maps, and block maxima on CPU, so the kernel rejected every input as non-GPU.Staging one parameter at a time preserves CPU offload between updates and avoids materializing all offloaded optimizer state on the GPU at once.
Impact
GaLoreAdamW8bitcan now train with FP32LowLevelZeroPluginCPU offload.Fixes #6399.
Validation
python -m pytest tests/test_optimizer/test_dist_galore.py -q(4 GPUs; 1 passed)compileallandgit diff --check: passed