Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HDF5 I/O of observations without detector data #809

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

tskisner
Copy link
Member

  • The default list of detdata fields for save / load is now the standard signal and flags.

  • An empty list of detdata fields is now interpreted as "no fields" rather than "all fields".

  • Add a unit test to check save / load with empty detector data.

- The default list of detdata fields for save / load is now the standard
  signal and flags.

- An empty list of detdata fields is now interpreted as "no fields" rather
  than "all fields".

- Add a unit test to check save / load with empty detector data.
@tskisner tskisner requested a review from keskitalo February 24, 2025 23:18
Copy link
Member

@keskitalo keskitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding a unit test for this use case.

@tskisner tskisner merged commit bf56358 into toast3 Feb 25, 2025
7 checks passed
@tskisner tskisner deleted the hdf5_nodet branch February 25, 2025 00:58
sbiquard pushed a commit to sbiquard/toast that referenced this pull request Feb 25, 2025
…mb#809)

- The default list of detdata fields for save / load is now the standard
  signal and flags.

- An empty list of detdata fields is now interpreted as "no fields" rather
  than "all fields".

- Add a unit test to check save / load with empty detector data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants