Use the detector polarization type to infer psi_pol in Pxx #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
approved these changes
Feb 22, 2025
| pol = props["pol"] | ||
| else: | ||
| pol = None | ||
| if pol == "A" or det.endswith(("a", "A", "t", "T")): |
There was a problem hiding this comment.
So this means that if the detector table happens to have a column named pol (with any value) and the detector name ends in A, it will trigger this branch. Is that fragile?
For simulated data from SO, this probably is fine since the det names end in "A" or "B" and there is a "pol" column with a matching value of "A" or "B".
For real SO data, the detectors have names like "Mv5_f150_Br06c04A", but we index the detectors by readout name (which doesn't end in "A", "B", "T", etc). So this is probably safe for that case.
In the future, if we find that we are running this operator frequently, we could create a trait that specifies the detector table column to use for psi_pol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two quick fixes to support ground-based conviqt simulations.