Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: JK BMS: add more values to live view #552

Merged

Conversation

schlimmchen
Copy link
Member

there are more interesting values available to display in the live view. however, adding them made the list of values very long. this can be mitigated by using a new column/card, which uses the available screen space nicely on bigger screens.

Live View in 2023.12.15:
Screenshot from 2023-12-14 21-40-07

Updated Live View:
image

@schlimmchen
Copy link
Member Author

@indie89 This was a fun little exercise 😊 Let me know what you think before I mark this pull request as ready.

@indie89
Copy link

indie89 commented Dec 17, 2023

@schlimmchen , 😲 crazy, that looks very good! I'd love to have it merged. Thanks so much, these values are all the important ones for me :-)

@schlimmchen schlimmchen force-pushed the jkbms-additional-live-view-card branch from aca4518 to 0fe810d Compare December 17, 2023 19:51
@schlimmchen
Copy link
Member Author

Made the process of preparing the new card more generic with less code while fixing the nodejs errors. I missed the errors since I used npm run dev and did not bother to build. Thanks to the github checks these could be addressed.

@schlimmchen schlimmchen marked this pull request as ready for review December 17, 2023 19:55
@schlimmchen schlimmchen force-pushed the jkbms-additional-live-view-card branch from 0fe810d to 4cd9e54 Compare December 28, 2023 15:43
@schlimmchen schlimmchen marked this pull request as draft December 28, 2023 15:44
@schlimmchen
Copy link
Member Author

Converted to draft as re-testing is required after rebasing onto current development branch, which includes a lot of changes (TaskSchedular in particular).

there are more interesting values available to display in the live view.
however, adding them made the list of values very long. this can be
mitigated by using a new column/card, which uses the available screen
space nicely on bigger screens.
@schlimmchen schlimmchen force-pushed the jkbms-additional-live-view-card branch from 4cd9e54 to 586b327 Compare December 29, 2023 21:40
@schlimmchen schlimmchen marked this pull request as ready for review December 29, 2023 21:40
@helgeerbe helgeerbe merged commit 7928f2f into hoylabs:development Dec 30, 2023
8 checks passed
@schlimmchen schlimmchen deleted the jkbms-additional-live-view-card branch December 30, 2023 15:51
Copy link

github-actions bot commented Apr 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants