Add 'fix' subcommand #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soon, I will add another command type that's neither lint nor tidy, which means this assertion needs to be a little more flexible.
I don't think this is quite right yet, and it needs a lot of docs and probably more tests. I also suspect the "both" type should be reconsidered.
|
This looks like a reasonable start. One thing I'd note is that AFAICT the code for tidying and fixing is very similar (which makes sense). There's probably an opportunity for more deduplication here, both in method bodies and in types. I think most of |
|
Given discussion in #44, I'm going to not go any further with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken a stab at this; it's not quite ready yet but I figured I'd open this anyway.
I suspect that at the very least, we'll want to reconsider the "both" moniker. I'll keep poking at this tomorrow; I'm not totally convinced it even works just yet, and it definitely needs tests and docs.