Feat: Add public API for tracking and reacting to controllers lifecycle #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophehenry
force-pushed
the
public-lifecycle
branch
3 times, most recently
from
1203e91 to
d3462df
Compare
christophehenry
commented
Sep 17, 2025
Comment on lines
+52
to
+54
| get lifecycle() { | ||
| return this.context.lifecycle | ||
| } |
Author
There was a problem hiding this comment.
I wonder is lifecycleIsAtLeast(lifecycle: Lifecycle), lifecycleIsAtMost(lifecycle: Lifecycle) and lifecycleIsBetween(from: Lifecycle, to: Lifecycle) utility functions are necessary here or if controller.lifecycle < Lifecycle.Initialized is sufficient?
christophehenry
commented
Sep 17, 2025
Comment on lines
+86
to
+96
| function onConnected() { | ||
| controller.element.addEventListener(`${controller.identifier}:connected`, removeEventListener) | ||
| // extend the controller | ||
| } | ||
|
|
||
| if(controller.lifecycle < Lifecycle.connected) { | ||
| controller.element.addEventListener(`${controller.identifier}:connected`, onConnected) | ||
| } else { | ||
| onConnected() | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
There could be a controller method for this pattern, IDK.
christophehenry
force-pushed
the
public-lifecycle
branch
from
d3462df to
c454de5
Compare
Author
|
Is this project abandonned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat related to #859. This PR proposes a public API to track and react to controller's lifecycle in order to simplfy writing Stimulus extensions. This API is constituted from 2 parts:
lifecycleproperty,There is currently no test on this. I'd appreciate any guidance on this matter. This is an early open to gather feedback as fast as possible.