Use a separate action cable server for hotwire-spark #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
force-pushed
the
isolated-ac-server
branch
3 times, most recently
from
24693c2 to
1aef8bd
Compare
This will isolate the connection from hotwire-spark from the connection used by the host app, which most likely will be authenticated. This fixes the problem where hotwire-spark doesn't work with unauthenticated connections. Fixes #19 This also lets us remove lots of complexity for the system monkeypatching the cable server to prevent restarts, since we don't want those when code reloads in development.
jorgemanrubia
force-pushed
the
isolated-ac-server
branch
from
1aef8bd to
9a76cff
Compare
jorgemanrubia
commented
Dec 21, 2024
jorgemanrubia
commented
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will isolate the hotwire-spark connection from the connection used by the host app, which most likely will be authenticated. This fixes the problem where hotwire-spark doesn't work with unauthenticated connections.
Fixes #19
This also lets us remove lots of complexity for the system monkeypatching the cable server to prevent restarts, since we don't want those when code reloads in development.