Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended the description in the incoming shipment creation flow #919

Open
wants to merge 2 commits into
base: implementations-pub
Choose a base branch
from
Open

Extended the description in the incoming shipment creation flow #919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8df1fd9
Added some description in Create_Corr_Transfer_In_Ship.md
Chinmay2107 Nov 22, 2024
fe890a5
Merge pull request #1 from Chinmay2107/create-corr-to-in-shipment
Chinmay2107 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions mephisto/Requirements/Transfer_Order_Flows/Create_Corr_Transfer_In_Ship.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,19 @@ This document highlights how Transfer Orders (TOs) will be managed after a recom
1. **Creating and Accepting Transfer Orders**
- After Transfer Order recommendations are generated, the merchandising team reviews and accepts the needed TOs.
-
- The merchandising team will create CSV file and upload them into HotWax using EXIM.
- Once the file is uplaoded an existing job within HotWax OMS creates the corresponding TOs.
- **Note**: More detail is required on this process.
- The merchandising team will create CSV file and upload them into HotWax using [Import Transfer Order]([url](https://mephisto-uat.hotwax.io/commerce/control/ImportData?configId=IMP_TRANSFER_ORD)) MDM.
- Once the file is uploaded an existing Import Transfer Order job within HotWax OMS creates the corresponding TOs.
- An existing job invokes `bulkApproveTransferOrders` service that approves the TOs in created status and reserves the inventory for the products.

2. **Fulfilling Transfer Orders**
- The store fulfills these accepted Transfer Orders and creates shipments for them with `"shipmentTypeId": "OUT_TRANSFER"`.
- This process already exists in HotWax OMS.
- **Note**: More detail is required on this process.

3. **Scheduled Job for Outgoing Transfers**
- A scheduled job will be created to pull all new `"OUT_TRANSFER"` shipments in the `"PURCH_SHIP_SHIPPED"` status.
- These shipments will be placed at an SFTP location for further processing.
- **Note**: The format of this file needs to be identified. Ideally, it should match the format used by the existing jobs. This is JSON
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line can also be deleted.

- **Note**: This job may be helpful here `generate_TransferOrderFulfilledItemsFeed"`
- **Note**: The`generate_TransferOrderFulfilledItemsFeed"` service generates the feed in JSON format.

4. **Using NiFi to Create Incoming Transfers**
- A NiFi flow will be created to process the files placed at the SFTP location.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NiFi has been created and tested. Details of the flow should be added here.

Expand All @@ -31,7 +30,7 @@ This document highlights how Transfer Orders (TOs) will be managed after a recom
- The file created by NiFi will be uploaded into OMS using configID: `IMP_SHIPMENT` and job: `createIncomingShipment`

### JOLT Transformation for Incoming Transfers
The following JOLT transformation is used create the new `"IN_TRANSFER"` shipment:
The following JOLT transformation is used to create the new `"IN_TRANSFER"` shipment:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a part of the NiFi flow.


```json
[
Expand All @@ -56,4 +55,4 @@ The following JOLT transformation is used create the new `"IN_TRANSFER"` shipmen

**Note**: The `OUT_TRANSFER` and the `IN_TRANSFER` are linked to the same order and shipment package, therefore most of the data will remain the same.

This JOLT transformation is designed based on the requirements for [creating incoming shipments](https://docs.google.com/document/d/1hOK8CAYw2TpBYudrHVOrFc5EbcPQAns2xB-VaRLDlZU/edit?usp=sharing) (`createincomingshipment`).
This JOLT transformation is designed based on the requirements for [creating incoming shipments](https://docs.google.com/document/d/1hOK8CAYw2TpBYudrHVOrFc5EbcPQAns2xB-VaRLDlZU/edit?usp=sharing) (`createincomingshipment`).