Add some tests for project and task routes #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Sujanadh
approved these changes
Apr 9, 2025
spwoodcock
reviewed
Apr 9, 2025
| @@ -817,7 +817,7 @@ async def update_project_form( | |||
| "project_id": project.id, | |||
| }, | |||
| ) | |||
| db.commit() | |||
There was a problem hiding this comment.
Good catch, but I'm not sure we really need db.commit() anywhere in the codebase to be honest:
- When an endpoint is called a transaction is started via a context manager
- Before the cursor / transaction is closed, the SQL is executed automatically
spwoodcock
reviewed
Apr 9, 2025
| xls_file = BytesIO(updated_xls_content) | ||
| xls_file.name = "form.xlsx" | ||
|
|
||
| with patch( |
There was a problem hiding this comment.
While this patch is good, we do run the entire stack for these tests (db, api, odk central), so you could get the actual response rather than doing a patch 👍
spwoodcock
reviewed
Apr 9, 2025
|
|
||
| contributor = data[0] | ||
| assert contributor["user"] == admin_user.username | ||
| assert contributor["contributions"] == 2 |
There was a problem hiding this comment.
It might be good to have this as >2 or something, as this could break in future if we added more tests that create task events
spwoodcock
approved these changes
Apr 9, 2025
|
Test coverage increase 68% --> 72% 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
Tests to: