Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: omit optional invoice contents from json sent to lexoffice #5

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

rwos
Copy link

@rwos rwos commented Feb 9, 2024

It would previously for example always send an empty paymentConditions { ... } thingy and then lexoffice complained that the paymentLabel is too short.

Not all of the omitempty fields are really optional (for example netAmount or grossAmount must be sent, depending on taxType) - but they shouldn't be sent with null-values when they are not set.

@rwos rwos self-assigned this Feb 9, 2024
@rwos rwos requested a review from till February 9, 2024 16:54
@rwos rwos merged commit 34d8d8d into master Feb 12, 2024
2 checks passed
@rwos rwos deleted the omit-optional-invoice-stuff branch February 12, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants