[ADDED] Semantic timeline parser testing. Updated nullable properties.
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossain-khan
commented
Mar 16, 2024
Comment on lines
+240
to
+245
| @Json(name = "TYPE_UNKNOWN") | ||
| TYPE_UNKNOWN( | ||
| "Type Unknown", | ||
| "The place has not been categorized.", | ||
| "#03a9f4", | ||
| ), |
There was a problem hiding this comment.
Needs to be ported back to spec.
…google-location-history into feat/use-semantic-timeline
hossain-khan
commented
Mar 16, 2024
Comment on lines
+114
to
+122
| /** | ||
| * Indicates the location information was provided by visiting location (e.g. on arrival). | ||
| */ | ||
| VISIT_ARRIVAL, | ||
|
|
||
| /** | ||
| * Indicates the location information was provided by visiting location (e.g. on departure). | ||
| */ | ||
| VISIT_DEPARTURE, |
There was a problem hiding this comment.
These two also needs to be added back to the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.