fix: better error if local changes cannot be synced (#94)

lib/init.js

@@ -55,6 +55,14 @@ function init (hoodie) {
   hoodie.account.on('pre:signout', function (options) {
     options.hooks.push(function () {
       return hoodie.store.push()
+      .catch(function (error) {
+        if (error.status !== 401) {
+          throw error
+        }
+
+        error.message = 'Local changes could not be synced, sign in first'
+        throw error
+      })
     })
   })
   hoodie.account.on('post:signout', function (options) {

tests/specs/init.js

@@ -210,6 +210,7 @@ test('"hoodie.store.push" is called on "pre:signout"', function (t) {
     store: {
       push: function () {
         t.pass('store.push called on "signout"')
+        return {catch: function () {}}
       }
     },
     connectionStatus: {
@@ -225,6 +226,37 @@ test('"hoodie.store.push" is called on "pre:signout"', function (t) {
   hooks[0]()
 })
 
+test('"hoodie.store.push" returns better error message if local changes cannot be synced', function (t) {
+  t.plan(2)
+
+  var UnauthorizedError = new Error('unauthorized')
+  UnauthorizedError.status = 401
+
+  var hoodie = {
+    account: {
+      id: 0,
+      on: simple.stub(),
+      isSignedIn: simple.stub()
+    },
+    store: {
+      push: simple.stub().rejectWith(UnauthorizedError)
+    },
+    connectionStatus: {
+      on: simple.stub()
+    }
+  }
+
+  init(hoodie)
+  var signOutHandler = findEventHandler(hoodie.account.on.calls, 'pre:signout')
+  var hooks = []
+  signOutHandler({hooks: hooks})
+  t.is(hooks.length, 1, 'one pre:signout hook registered')
+  hooks[0]()
+    .catch(function (error) {
+      t.is(error.message, 'Local changes could not be synced, sign in first')
+    })
+})
+
 test('"hoodie.store.*" is *not* called when "hoodie.account.isSignedIn()" returns "false"', function (t) {
   t.plan(2)