prisma integration #405

imran1khan · 2024-06-19T07:04:56Z

issue #384
bro, if you need any help feel free to contact, i have made the nessery changes, hopefully you are going to like it

i have added a doc for prisma installation, i hope it's going to be helpfull for someone who want's to know how to install prisma in cloudflare workers, if you like my work feel free to contact me,

i have added docs related to how we can use prisma accelerate but i have not added any doc, on how we can use prisma using Database driver, because it's very easy to do and anyone can read the doc link that i have provied and understand this

NicoPlyley · 2024-06-19T07:49:04Z

@yusukebe Do you mind if I do a code review here?
I have a few recommendations and updates.

imran1khan · 2024-06-19T08:40:08Z

@NicoPlyley bro feel free to add your ideas, it would be a great helpand learning

NicoPlyley

Good point. Here are my suggestions, we can also see if @yusukebe agrees with my updates if you'd like

Update:
I meant to hit request changes, I clicked approve on accident.

.vitepress/config.ts

NicoPlyley · 2024-06-19T07:53:01Z

examples/prisma.md

@@ -0,0 +1,116 @@
+# Prisma


Update heading:
"Using Prisma on Cloudflare Workers" or something similar

NicoPlyley · 2024-06-19T07:54:34Z

examples/prisma.md

+- Enable Accelerate
+- Enable Driver Adapters
+
+### Start Prisma


Use the second heading for all the sections so and I would say install or setup instead of start:
## Install Prisma

NicoPlyley · 2024-06-19T07:57:57Z

examples/prisma.md

+There are two ways to use Prisma in your Cloudflare Workers:
+
+- Enable Accelerate
+- Enable Driver Adapters


Since this tutorial does not have the driver adapter section I would update this text a little. Something like this:
"There are two ways to use Prisma with Cloudflare Workers, we will be using Prisma Accelerate, but you can also use the Prisma Driver Adapter" and add a link there to the driver adapters instead of at the bottom.

NicoPlyley · 2024-06-19T08:02:16Z

examples/prisma.md

+First, start Prisma on your Hono Cloudflare Workers. Here, I am using neon.tech as my PostgreSQL database, but you can use whichever database suits your project.
+


Change "start" to "install".

For neon say I am using the [neon.tech](https://neon.tech/) free tier...

NicoPlyley · 2024-06-19T08:20:49Z

examples/prisma.md

+```ts
+generator client {
+  provider = "prisma-client-js"
+}
+
+datasource db {
+  provider = "postgresql"
+  url      = env("DATABASE_URL")
+  directUrl = env("DIRECT_URL")
+}
+```


Add code block like above

NicoPlyley · 2024-06-19T08:21:06Z

examples/prisma.md

+```ts
+import { PrismaClient } from '@prisma/client/edge'
+import { withAccelerate } from '@prisma/extension-accelerate'
+
+export const getPrisma = (database_url: string) => {
+    const prisma = new PrismaClient({
+        datasourceUrl: database_url,
+      }).$extends(withAccelerate());
+    return prisma
+}
+```


Add code block

NicoPlyley · 2024-06-19T08:21:16Z

examples/prisma.md

+```ts
+import { Hono } from 'hono';
+import { sign, verify } from 'hono/jwt';
+import { getPrisma } from '../usefulFun/prismaFun';
+
+// Create the main Hono app
+const app = new Hono<{
+  Bindings: {
+    DATABASE_URL: string
+    JWT_SECRET: string
+  },
+  Variables: {
+    userId: string,
+  }
+}>();
+
+app.post('/', async (c) => {
+    // Now you can use it wherever you want
+    const prisma = getPrisma(c.env?.DATABASE_URL);
+});
+```


Add code block

NicoPlyley · 2024-06-19T08:21:39Z

examples/prisma.md

+# Enable Driver Adapters
+
+To enable [Database Driver](https://www.prisma.io/docs/orm/overview/databases/database-drivers), read the documentation.
+
+---


This can now be removed since we simplified it above

NicoPlyley · 2024-06-19T08:22:18Z

package-lock.json

This file can be deleted, there is no lock file added to this repo

imran1khan · 2024-06-19T15:34:42Z

@NicoPlyley hi bro, please check out the new update that i made, bro i am seriously sorry for making so much mistake but thanks so much for your greate help,
and if i made some mistake again then feel free to currect me.
thanks so much.
one question i had was, why we have to make another .dev.vars file because when we run prisma init it's going to create .env file so, do we have to delete that .env file after coping the content into the .dev.vars? because i thought prisma in not going to run without .env file

NicoPlyley · 2024-06-19T20:30:23Z

@imran1khan
First off you did a great job. Most the updates were just to add a bit of simplicity.
I am unsure about the .env file with prisma so if the cli needs it then go ahead a leave that in. You might want to specify that in there too.

updated syntex mistake new syntex added

imran1khan · 2024-06-19T22:11:03Z

@NicoPlyley bro, thanks for your suggestion, i have added the .env and explained it too. i know your time is precious, but let me know if you want some outher correction. and also i have squash the commits so,i thought it's good to let you know

yusukebe · 2024-06-20T03:55:37Z

package-lock.json

Can you remove this file from the PR? It's unnecessary.

hi, @yusukebe i have removed the package.-lock.json, as you asked.

yusukebe · 2024-06-20T03:57:39Z

Sorry for the late reply.

@yusukebe Do you mind if I do a code review here?

Yeah!

yusukebe · 2024-06-20T04:08:32Z

examples/prisma.md

@@ -0,0 +1,118 @@
+# Using Prisma on Cloudflare Workers
+
+There are two ways to use Prisma with Cloudflare Workers, we will be using Prisma Accelerate, but you can also use the Prisma [Driver Adapter](https://www.prisma.io/docs/orm/overview/databases/database-drivers)


Add . to last.

yusukebe · 2024-06-20T04:09:18Z

examples/prisma.md

+
+Go to [neon.tech](https://neon.tech/) and create a free PostgreSQL database.
+
+```ts


It should be bash instead of ts.

yusukebe · 2024-06-20T04:10:18Z

examples/prisma.md

+
+Create a function like this, which you can use in your project later:
+::: code-group
+```ts


What about adding the file name?

@yusukebe, bro, I have changed all the necessary things that you asked, but I did not mention the file name because we can make this function anywhere we want, so it's not file-specific. You can make this in your root folder and use it anywhere you want, so I am not sure what file name to put here. If you want me to write that in detail, let me know.

So the main file you can call index.ts and this file you can name it whatever the import is on the index.ts file. That way it's clear to people that two separate files are being working in

Currently, the tab names are ts:

How about adding a file name like this?

::: code-group ```ts [filename.ts]

@yusukebe
bro, can i name the main working file as main.ts and the function file as index.ts,
or the main working file as index.ts and the function file as prismafunction.ts

examples/prisma.md

yusukebe · 2024-06-20T04:12:18Z

Hey @imran1khan !

This is great! I've left some comments. Please check them.

NicoPlyley · 2024-06-20T09:21:08Z

examples/prisma.md

+To setup Accelerate, go to [Prisma Accelerate](https://www.prisma.io/data-platform/accelerate?via=start&gad_source=1&gclid=CjwKCAjwvIWzBhAlEiwAHHWgvX8l8e7xQtqurVYanQ6LmbNheNvCB-4FL0G6BFEfPrUdGyH3qSllqxoCXDoQAvD_BwE) and log in.
+
+After logging in, you will be taken to a page where you can create a new Accelerate project. and log in or register for free
+


Update this to

To setup Accelerate, go to [Prisma Accelerate](https://www.prisma.io/data-platform/accelerate?via=start&gad_source=1&gclid=CjwKCAjwvIWzBhAlEiwAHHWgvX8l8e7xQtqurVYanQ6LmbNheNvCB-4FL0G6BFEfPrUdGyH3qSllqxoCXDoQAvD_BwE) and log in or register for free. After logging in, you will be taken to a page where you can create a new Accelerate project.

examples/prisma.md

NicoPlyley · 2024-06-20T09:27:05Z

@imran1khan I added three things. I checked over it a few times I think it should be good after that. Yusuke will check again as well.

Thanks for continuing and update this and contributing!

imran1khan · 2024-06-20T09:39:11Z

@NicoPlyley , thnaks bro for taking your time and helping me, i am new to this, and i am very glad that you are so patience with me. so thanks alot. and let me know for some new addition

yusukebe · 2024-06-21T06:07:13Z

Hey @imran1khan

Please check my comment!

imran1khan · 2024-06-21T06:28:30Z

@yusukebe, bro i have added the main working file as index.ts and the function file from which i am importing the function as prismaFunction.ts, i hope it works. but let me know your suggestion

yusukebe

LGTM!

yusukebe · 2024-06-21T06:32:55Z

@imran1khan

Gooood! Thank you for your contribution!

@NicoPlyley also thank you for reviewing.

Let's go with it 🎉

imran1khan · 2024-06-21T18:30:18Z

@yusukebe thanks bro, i really appreciate your work and your help

NicoPlyley approved these changes Jun 19, 2024

View reviewed changes

imran1khan requested a review from NicoPlyley June 19, 2024 15:37

prisma integration

c7e9e66

updated syntex mistake new syntex added

imran1khan force-pushed the prismaInte branch from f5e0074 to c7e9e66 Compare June 19, 2024 22:06

yusukebe reviewed Jun 20, 2024

View reviewed changes

imran1khan added 2 commits June 20, 2024 14:23

added package-lock.json to .gitignore

0312279

package-lock.json removed

b4dae4b

NicoPlyley reviewed Jun 20, 2024

View reviewed changes

examples/prisma.md Outdated Show resolved Hide resolved

file name added

f1737a1

file name added

6b409e6

yusukebe approved these changes Jun 21, 2024

View reviewed changes

yusukebe merged commit 43fb25e into honojs:main Jun 21, 2024

imran1khan deleted the prismaInte branch June 21, 2024 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prisma integration #405

prisma integration #405

imran1khan commented Jun 19, 2024 •

edited

Loading

NicoPlyley commented Jun 19, 2024

imran1khan commented Jun 19, 2024

NicoPlyley left a comment •

edited

Loading

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

NicoPlyley Jun 19, 2024

imran1khan commented Jun 19, 2024

NicoPlyley commented Jun 19, 2024

imran1khan commented Jun 19, 2024 •

edited

Loading

yusukebe Jun 20, 2024

imran1khan Jun 20, 2024

yusukebe commented Jun 20, 2024

yusukebe Jun 20, 2024

yusukebe Jun 20, 2024

yusukebe Jun 20, 2024

imran1khan Jun 20, 2024

NicoPlyley Jun 20, 2024

yusukebe Jun 21, 2024

imran1khan Jun 21, 2024

yusukebe commented Jun 20, 2024

NicoPlyley Jun 20, 2024

NicoPlyley commented Jun 20, 2024

imran1khan commented Jun 20, 2024

yusukebe commented Jun 21, 2024

imran1khan commented Jun 21, 2024

yusukebe left a comment

yusukebe commented Jun 21, 2024

imran1khan commented Jun 21, 2024

		First, start Prisma on your Hono Cloudflare Workers. Here, I am using neon.tech as my PostgreSQL database, but you can use whichever database suits your project.

		@@ -0,0 +1,118 @@
		# Using Prisma on Cloudflare Workers

		There are two ways to use Prisma with Cloudflare Workers, we will be using Prisma Accelerate, but you can also use the Prisma [Driver Adapter](https://www.prisma.io/docs/orm/overview/databases/database-drivers)


		Go to [neon.tech](https://neon.tech/) and create a free PostgreSQL database.

		```ts

		To setup Accelerate, go to [Prisma Accelerate](https://www.prisma.io/data-platform/accelerate?via=start&gad_source=1&gclid=CjwKCAjwvIWzBhAlEiwAHHWgvX8l8e7xQtqurVYanQ6LmbNheNvCB-4FL0G6BFEfPrUdGyH3qSllqxoCXDoQAvD_BwE) and log in.

		After logging in, you will be taken to a page where you can create a new Accelerate project. and log in or register for free

prisma integration #405

prisma integration #405

Conversation

imran1khan commented Jun 19, 2024 • edited Loading

NicoPlyley commented Jun 19, 2024

imran1khan commented Jun 19, 2024

NicoPlyley left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imran1khan commented Jun 19, 2024

NicoPlyley commented Jun 19, 2024

imran1khan commented Jun 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yusukebe commented Jun 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yusukebe commented Jun 20, 2024

Choose a reason for hiding this comment

NicoPlyley commented Jun 20, 2024

imran1khan commented Jun 20, 2024

yusukebe commented Jun 21, 2024

imran1khan commented Jun 21, 2024

yusukebe left a comment

Choose a reason for hiding this comment

yusukebe commented Jun 21, 2024

imran1khan commented Jun 21, 2024

imran1khan commented Jun 19, 2024 •

edited

Loading

NicoPlyley left a comment •

edited

Loading

imran1khan commented Jun 19, 2024 •

edited

Loading