Update Vercel page #297
Merged
Update Vercel page #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See honojs/node-server#84 Based on manual testing, this only affects the Node js runtime on the pages router: the app router as a whole and edge API routes in the pages router are unaffected.
|
Thanks! Great. I'll merge this now. |
cogoo
added a commit
to christex-foundation/mocha-core-api
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, and thanks for Hono! I've made two changes to the Vercel docs:
configobject that some of the API routes use500responses when includingbodypayload in any request using@hono/node-server/vercelnode-server#84, I updated the pages router Node.js example to have thebodyParsersetting turned off. Based on my manual testing, this issue only affects the pages router API routes running on Node.js: the app router as a whole and page router edge API routes are not affected and as such don't need bodyParser turned off.