Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of
ENV
and theenv
option.For Cloudflare Pages, the current
cf
option allows us to use bindings. For example:With this configuration, we can access variables through
c.env
:This is currently exclusive to Cloudflare Pages, but in the future, it may be extended to other runtimes/platforms with specific environment values. While
c.env
seems to be used for Cloudflare, other platforms/runtimes may also use bindings/c.env
. For instance, the AWS Lambda adapter currently usesenv
:https://github.com/honojs/hono/blob/main/src/adapter/aws-lambda/handler.ts#L126-L143
This PR suggests separating the Cloudflare Pages-specific functionality from
dev-server.ts
. With this change, thegetEnv()
method for Cloudflare Pages is placed incloudflare-pages/index.ts
, and users can include theenv
in theirvite.config.ts
:With this mechanism, adding support for another platform that uses environment variables becomes straightforward: