Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler & miniflare dependencies as optional peerDependencies #164

Closed
wants to merge 3 commits into from

Conversation

arisris
Copy link
Contributor

@arisris arisris commented Aug 26, 2024

This is my first PR. I want join to the honojs community.

Since dev-server is not required to use cloudflare adapter,
as it so i try to move miniflare dependencies into devDependencies and add them into optional peerDependencies including wrangler.

also i try to add bun & node adapter.

Thankyou

Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: 8f65baf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yusukebe
Copy link
Member

Hi @arisris !

Thank you for your first PR! I want to review it, but can you separate this PR to the 3 PRs?

  1. Removing miniflare deps.
  2. Bun adapter.
  3. Node.js adapter.

@arisris
Copy link
Contributor Author

arisris commented Aug 26, 2024

@yusukebe Thanks. I will do it tomorow. After done i will close this PR

@arisris
Copy link
Contributor Author

arisris commented Aug 27, 2024

I have separate this with 3 PRs
#165
#166
#167

@arisris arisris closed this Aug 27, 2024
@yusukebe
Copy link
Member

@arisris

Thanks! I'll see them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants