Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudflare-pages): custom _routes.json #135

Merged
merged 4 commits into from
May 9, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented May 8, 2024

Creating a public/_routes.json will override the automatic generation.
This is useful when we want to write include/exclude accurately.

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 2613ca9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/vite-cloudflare-pages Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

yusukebe commented May 9, 2024

Hi @ryuapp

Sounds good! One thing, could you run yarn changeset at the top of the project and push it? This will be a minor change.

@ryuapp
Copy link
Contributor Author

ryuapp commented May 9, 2024

Thank you for your check, @yusukebe.
I add a changeset.
In addition, I write the description for custom _routes.json in README and adjust test a bit.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented May 9, 2024

In addition, I write the description for custom _routes.json in README and adjust test a bit.

Cool!

Let's ship it. Thanks!

@yusukebe yusukebe merged commit 25bfb61 into honojs:main May 9, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request May 9, 2024
@ryuapp ryuapp deleted the custom-routes-json branch May 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants