Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter/aws-lambda): remove unneeded import and compatibility for LLRT #3915

Merged
merged 5 commits into from
Feb 13, 2025
+0 −5
Merged

fix(adapter/aws-lambda): remove unneeded import and compatibility for LLRT #3915

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e80ce9b
fix(lambda-edge): remove
EdamAme-x Feb 12, 2025
bfe4791
changne aprocach
EdamAme-x Feb 12, 2025
0ba7a10
Revert "fix(lambda-edge): remove"
EdamAme-x Feb 12, 2025
f6a6668
revert
EdamAme-x Feb 12, 2025
4fd4811
revert 2
EdamAme-x Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/adapter/aws-lambda/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import crypto from 'node:crypto'
import type { Hono } from '../../hono'
import type { Env, Schema } from '../../types'
import { decodeBase64, encodeBase64 } from '../../utils/encode'
Expand All @@ -10,10 +9,6 @@
LambdaContext,
} from './types'

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
globalThis.crypto ??= crypto

export type LambdaEvent = APIGatewayProxyEvent | APIGatewayProxyEventV2 | ALBProxyEvent

// When calling HTTP API or Lambda directly through function urls
Expand Down Expand Up @@ -341,9 +336,9 @@

protected getCookies(
// eslint-disable-next-line @typescript-eslint/no-unused-vars
event: Exclude<LambdaEvent, APIGatewayProxyEventV2>,

Check failure on line 339 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Main 

'event' is declared but its value is never read.

Check failure on line 339 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Node.js v18.18.2 

'event' is declared but its value is never read.

Check failure on line 339 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / workerd 

'event' is declared but its value is never read.

Check failure on line 339 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Node.js v20.x 

'event' is declared but its value is never read.

Check failure on line 339 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Node.js v22.x 

'event' is declared but its value is never read.
// eslint-disable-next-line @typescript-eslint/no-unused-vars
headers: Headers

Check failure on line 341 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Main 

'headers' is declared but its value is never read.

Check failure on line 341 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Node.js v18.18.2 

'headers' is declared but its value is never read.

Check failure on line 341 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / workerd 

'headers' is declared but its value is never read.

Check failure on line 341 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Node.js v20.x 

'headers' is declared but its value is never read.

Check failure on line 341 in src/adapter/aws-lambda/handler.ts

View workflow job for this annotation

GitHub Actions / Node.js v22.x 

'headers' is declared but its value is never read.
): void {
// nop
}
Expand Down
Loading