Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): merge deno runtime coverage #3456

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

usualoma
Copy link
Member

@usualoma usualoma commented Sep 27, 2024

Checking the results in github actions...

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (f87c221) to head (ebf9ea7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3456      +/-   ##
==========================================
- Coverage   95.58%   94.91%   -0.68%     
==========================================
  Files         155      155              
  Lines        9357     9884     +527     
  Branches     2779     2796      +17     
==========================================
+ Hits         8944     9381     +437     
- Misses        413      501      +88     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usualoma
Copy link
Member Author

usualoma commented Sep 27, 2024

On Codecov, the coverage results for "coverage/deno-runtime-coverage.lcov" overwrite the results for main, resulting in a lower coverage rate. It would be nice if the results could be merged.

@usualoma usualoma marked this pull request as draft September 27, 2024 06:57
@usualoma usualoma force-pushed the merge-deno-runtime-coverage branch 5 times, most recently from 92e391c to 19c8486 Compare September 28, 2024 02:47
@usualoma
Copy link
Member Author

When generating lcov format data from deno coverage, some comment lines are incorrectly treated as executable lines, resulting in unnecessary uncovered.

CleanShot 2024-09-28 at 13 48 42@2x

CleanShot 2024-09-28 at 13 51 33@2x

@usualoma usualoma changed the title [POC] test(deno): merge deno runtime coverage test(deno): merge deno runtime coverage Sep 28, 2024
@usualoma usualoma mentioned this pull request Sep 28, 2024
4 tasks
@usualoma usualoma changed the title test(deno): merge deno runtime coverage chore(test): merge deno runtime coverage Sep 28, 2024
@usualoma
Copy link
Member Author

I have created a pull request to fix this issue in deno. Whether or not it is merged is up to deno.

denoland/deno#25939

@yusukebe
Copy link
Member

@usualoma Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants