Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context): added APPLICATION_JSON constant #3370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marceloverdijk
Copy link
Contributor

This adds the APPLICATION_JSON = 'application/json; charset=UTF-8' constant which is used in the .json() helper (and now can be re-used).

Note: this is similar as the existing TEXT_PLAIN = 'text/plain; charset=UTF-8' constant already present.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@marceloverdijk marceloverdijk changed the title feat(context): added application json constant feat(context): added APPLICATION_JSON constant Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (3500404) to head (31c6f0b).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3370    +/-   ##
========================================
  Coverage   95.77%   95.77%            
========================================
  Files         152      152            
  Lines        9187     9188     +1     
  Branches     2818     2687   -131     
========================================
+ Hits         8799     8800     +1     
  Misses        388      388            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member

yusukebe commented Sep 8, 2024

Hi @marceloverdijk

I have some ideas for treating constants. I'll share them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants