Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: confirm all questions before init repo #70

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

MathurAditya724
Copy link
Contributor

@MathurAditya724 MathurAditya724 commented Sep 2, 2024

Closes #36

  • I have used EventEmitter to detect the events, this keeps the changes to a minimum.

There are 2 events that matter -

  1. Template download complete
  2. Dependencies installed

Whenever an event is completed .emit() function is called and the .on() event handler takes it from there.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Sep 3, 2024

Hi @MathurAditya724

Coool! I've tried it on my machine; it works well, and the experience is great. I'll merge it now. Thank you!

@yusukebe yusukebe changed the title fix: confirm all questions before init repo feat: confirm all questions before init repo Sep 3, 2024
@yusukebe yusukebe merged commit 44555b4 into honojs:main Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download a template after all choices
2 participants