Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't assume attribute type in oteltracing #1483

Merged
merged 3 commits into from
Feb 12, 2025
Merged

fix: don't assume attribute type in oteltracing #1483

merged 3 commits into from
Feb 12, 2025

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Feb 7, 2025

Which problem is this PR solving?

When a non-string type value is passed in to the AddTelemetryAttributeFunc when OTELTracing is enabled, Refinery currently panics

Short description of the changes

  • don't assume the attribute type

@VinozzZ VinozzZ requested a review from a team as a code owner February 7, 2025 21:05
@VinozzZ VinozzZ self-assigned this Feb 7, 2025
kentquirk
kentquirk approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thanks.

@VinozzZ VinozzZ merged commit d9224c4 into main Feb 12, 2025
5 checks passed
@VinozzZ VinozzZ deleted the yingrong/fix_panic_in_tracing branch February 12, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinozzZ @kentquirk @JamieDanielson