Skip to content

Conversation

@agners
Copy link
Member

@agners agners commented Nov 12, 2025

Proposed change

Since not all properties are safe to access the current code avoids adding any context during initialization and setup phase. However, quite some reports are during the setup phase. This change adds some context to events during setup phase as well, to make debugging easier.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:
  • Link to client library pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

Since not all properties are safe to access the current code avoids
adding any context during initialization and setup phase. However,
quite some reports are during the setup phase. This change adds some
context to events during setup phase as well, to make debugging easier.
@agners agners added the new-feature A new feature label Nov 12, 2025
@agners agners requested a review from Copilot November 12, 2025 13:44
Copilot finished reviewing on behalf of agners November 12, 2025 13:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances Sentry error reporting during the SETUP phase by adding basic system context information that was previously only available after full startup. The change helps with debugging issues that occur during supervisor initialization.

  • Adds Docker version, Supervisor version, architecture, and machine info to Sentry events during SETUP state
  • Updates tests to verify the new context is properly added during SETUP

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
supervisor/misc/filter.py Adds conditional logic to populate Sentry event context with basic system info when CoreState is SETUP
tests/misc/test_filter_data.py Updates test assertions to verify new context fields are present during SETUP state

@mdegat01 mdegat01 merged commit 69ae8db into main Nov 12, 2025
23 checks passed
@mdegat01 mdegat01 deleted the add-context-during-setup branch November 12, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants