-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to holidays config form #133589
Comments
Hey there @jrieger, @gjohansson-ST, mind taking a look at this issue as it has been labeled with an integration ( Code owner commandsCode owners of
(message by CodeOwnersMention) holiday documentation |
Yes, I think that wasn't a thing when A contribution would be welcome 👍 , be sure to use the regular I will make a contribution myself to |
I have made a PR now for |
PR pushed! (linked above). I sure took inspiration as I'm new to contributing to core. Feel free to be honest if you review it, don't worry about my ego. |
The problem
I recently set up the holidays integration for my country (France), and was left puzzled at the second step:
As a Frenchman living in mainland France, I have no idea what those abbreviations mean. The second issue is that It wasn't obvious to me that step was optional.
I've started solving this issue by contributing to the holidays project itself, both to their documentation and to the source code: vacanza/holidays#2162
Now I'd like HA to make use of that
subdivisions_aliases
when available to present a more user-friendly list of options. The holidays project follows ISO 3166-2, which is great for machines, not so much for humans.I've pinpointed the code in core, but before spending more time, I'd like to know if you'd be be interested in such a contribution.
On a side note, it's not just France. I've checked other countries have defined plain-text aliases in holidays, like Italy or New Zealand, so it would benefit to users of those countries as well.
What version of Home Assistant Core has the issue?
core-2024.12.4
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
holiday
Link to integration documentation on our website
https://www.home-assistant.io/integrations/holiday
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: