Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to holidays config form #133589

Open
bors-ltd opened this issue Dec 19, 2024 · 4 comments · May be fixed by #133663
Open

Improvement to holidays config form #133589

bors-ltd opened this issue Dec 19, 2024 · 4 comments · May be fixed by #133663
Assignees

Comments

@bors-ltd
Copy link

The problem

I recently set up the holidays integration for my country (France), and was left puzzled at the second step:

Screenshot 2024-12-11 at 10-45-56 Paramètres – Home Assistant

As a Frenchman living in mainland France, I have no idea what those abbreviations mean. The second issue is that It wasn't obvious to me that step was optional.

I've started solving this issue by contributing to the holidays project itself, both to their documentation and to the source code: vacanza/holidays#2162

Now I'd like HA to make use of that subdivisions_aliases when available to present a more user-friendly list of options. The holidays project follows ISO 3166-2, which is great for machines, not so much for humans.

I've pinpointed the code in core, but before spending more time, I'd like to know if you'd be be interested in such a contribution.

On a side note, it's not just France. I've checked other countries have defined plain-text aliases in holidays, like Italy or New Zealand, so it would benefit to users of those countries as well.

What version of Home Assistant Core has the issue?

core-2024.12.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

holiday

Link to integration documentation on our website

https://www.home-assistant.io/integrations/holiday

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @jrieger, @gjohansson-ST, mind taking a look at this issue as it has been labeled with an integration (holiday) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of holiday can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign holiday Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


holiday documentation
holiday source
(message by IssueLinks)

@gjohansson-ST
Copy link
Member

Yes, I think that wasn't a thing when holiday was made and workday which is built on the same lib has the same issue I guess.

A contribution would be welcome 👍 , be sure to use the regular subdivisions for values and that we use subdivisions_aliases only to provide labels (when available).

I will make a contribution myself to workday with this, and then I hope to see a PR from you closing this issue with a PR for holiday 🚀

@gjohansson-ST
Copy link
Member

I have made a PR now for workday. Feel free to get inspired (linked it to this issue)

@bors-ltd bors-ltd linked a pull request Dec 20, 2024 that will close this issue
19 tasks
@bors-ltd
Copy link
Author

PR pushed! (linked above). I sure took inspiration as I'm new to contributing to core.

Feel free to be honest if you review it, don't worry about my ego.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants