Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grohe_smarthome images for custom integration #6305

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

Flo-Schilli
Copy link
Contributor

Proposed change

This will add images for the Grohe Smarthome custom integration which will integrate Grohe Blue and Sense devices and is reflecting the namings from Grohe

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/Flo-Schilli/ha-grohe_smarthome

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Flo-Schilli 👋

It seems like the provided branding provided are application icons. However, we collect manufacturer branding in this repository, which in this case differs. Their website shows this:

CleanShot 2025-01-02 at 12 19 35

../Frenck

@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 2, 2025 11:20
@Flo-Schilli
Copy link
Contributor Author

Hi @frenck 👋

thanks for the hint. I just replaced them with the brand logo instead of the application logo.

../Schilli

@Flo-Schilli Flo-Schilli marked this pull request as ready for review January 2, 2025 14:27
@home-assistant home-assistant bot requested a review from frenck January 2, 2025 14:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Flo-Schilli 👍

../Frenck

@frenck frenck merged commit 874ac9e into home-assistant:master Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants