Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding for azure_storage #6292

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Dec 27, 2024

Proposed change

SSIA

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jan 2, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I could not find a reference for the branding used here. Could you point me to a resource?

../Frenck

@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 2, 2025 11:47
@zweckj
Copy link
Member Author

zweckj commented Jan 2, 2025

Hmm... I could not find a reference for the branding used here. Could you point me to a resource?

../Frenck

it's just the icon taken from Azure Portal
image

@frenck frenck marked this pull request as ready for review January 2, 2025 20:24
@home-assistant home-assistant bot requested a review from frenck January 2, 2025 20:24
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants