Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minim custom integration logo and icon #6291

Closed
wants to merge 2 commits into from

Conversation

nidble
Copy link
Contributor

@nidble nidble commented Dec 27, 2024

Proposed change

Added Minim logo and icon images

https://github.com/nidble/minim_alarm

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @nidble 👋

The provided branding seems to differ from the manufacturer branding:

CleanShot 2025-01-02 at 12 09 41

Could you please take a look and make sure the branding matches?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 2, 2025 11:10
@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@nidble
Copy link
Contributor Author

nidble commented Jan 2, 2025

Hello @frenck, yes for Inim integration a set of suitable images was already covered by this PR #5571. However, Inim license is very restrictive, and it prohibits any usage of their logo and image: general conditions
So for getting rid of any license issue/problem I created Minim.

wdyt? Thanks

@frenck
Copy link
Member

frenck commented Jan 2, 2025

Unfortunately, we will not accept custom branding creations. The problem with those, is that if a brand is misrepresented often leads to other issues as well.

Integrations, however, do not require branding and function perfectly fine without. So, that leave you with the choice to either update the branding to represent it correctly, or closing the PR and leave the integration without it (as that is fine too).

../Frenck

@nidble nidble closed this Jan 3, 2025
@nidble
Copy link
Contributor Author

nidble commented Jan 3, 2025

It sounds good for me! Thank you!

@nidble nidble reopened this Jan 3, 2025
@nidble nidble closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants