Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piper: update voices #3710

Merged
merged 4 commits into from
Aug 6, 2024
Merged

piper: update voices #3710

merged 4 commits into from
Aug 6, 2024

Conversation

joshuadavidson
Copy link
Contributor

@joshuadavidson joshuadavidson commented Jul 31, 2024

The following voices are present and can be selected in an voice assist pipeline, but cannot be selected in the Piper addon for default use in tts service calls:

  • cy_GB-gwryw_gogleddol-medium
  • en_US-bryce-medium
  • en_US-john-medium
  • en_US-norman-medium
  • it_IT-paola-medium

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Introduced several new voice options, including "gwryw_gogleddol," "bryce," "john," "norman," and "paola," to enhance the text-to-speech experience.
  • Updates
    • Updated the text-to-speech system version from 1.5.1 to 1.5.2, reflecting the latest improvements and features.
  • Documentation
    • Updated the changelog to include details about the new voice options in version 1.5.2.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joshuadavidson

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft July 31, 2024 22:10
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

coderabbitai bot commented Jul 31, 2024

Walkthrough

Walkthrough

The recent update to the Piper text-to-speech system introduces version 1.5.2, expanding its voice options significantly. This version adds five new voices: gwryw_gogleddol, bryce, john, norman, and paola, enhancing the user experience with greater variety. The version change, along with these additions, demonstrates ongoing efforts to improve the system's functionality, while other configuration settings remain unchanged.

Changes

File Change Summary
piper/config.yaml Updated version from 1.5.1 to 1.5.2; added new voices gwryw_gogleddol, bryce, john, norman, and paola.
piper/CHANGELOG.md Added entry for version 1.5.2 detailing the new voice options and their impact on functionality.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 348f2ca and 06fa266.

Files selected for processing (1)
  • piper/CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • piper/CHANGELOG.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joshuadavidson joshuadavidson marked this pull request as ready for review July 31, 2024 23:09
@agners
Copy link
Member

agners commented Aug 5, 2024

Thanks for your PR! 🙏

The en_US-norman-medium voice is present and can be selected in an voice assist pipeline, but cannot be selected in the Piper addon for default use in tts service calls.

From what I can tell norman got added by this commit: rhasspy/piper@40c852d. Can you also add the others which got added there?

@joshuadavidson
Copy link
Contributor Author

Thanks for this commit reference! I was looking for the source of truth to get them all in one go. I'll update.

@joshuadavidson joshuadavidson changed the title piper: add en_US-norman-medium to voice list piper: update voices Aug 5, 2024
@joshuadavidson
Copy link
Contributor Author

@coderabbitai full review

@joshuadavidson
Copy link
Contributor Author

@coderabbitai summary

piper/CHANGELOG.md Outdated Show resolved Hide resolved
@agners agners merged commit 0e4a883 into home-assistant:master Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants