matter_server: Bump Python Matter server to 6.4.0 #3706
Conversation
Bump the Python Matter server to the latest release. Also use the add-on config directory as location for the OTA provider. This allows to see logs and provide local update files for testing and development.
WalkthroughWalkthroughThe update introduces significant enhancements to the Python Matter Server, including an upgrade to version 6.4.0, improved configuration options in Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
matter_server/config.yaml (1)
23-27: Issues Found: Unused Configuration OptionsThe new configuration options
addon_configanddataare defined inmatter_server/config.yamlbut are not utilized in the codebase.
matter_server/config.yaml
addon_configdataPlease ensure these configuration options are correctly referenced and utilized in the codebase.
Analysis chain
LGTM! But verify the usage of new configuration options.
The new
mapsection entries foraddon_configanddatalook good.However, ensure that these new configuration options are correctly utilized in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new configuration options. # Test: Search for the usage of `addon_config` and `data` in the codebase. Expect: Correct utilization of these options. rg --type yaml -A 5 $'addon_config' rg --type yaml -A 5 $'data'Length of output: 3684
Script:
#!/bin/bash # Description: Verify the usage of new configuration options in the codebase. # Search for the usage of `addon_config` in the codebase. rg 'addon_config' -t yaml -t py -A 5 # Search for the usage of `data` in the codebase. rg 'type: data' -t yaml -t py -A 5Length of output: 1990
The data directory is mapped implicitly, so drop the explicit configuration.
| @@ -1,5 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ## 6.4.0 | |||
|
|
|||
| - Bump Python Matter Server to [6.4.0](https://github.com/home-assistant-libs/python-matter-server/releases/tag/6.4.0) | |||
There was a problem hiding this comment.
We didn't bump the server version in build.yaml.
There was a problem hiding this comment.
Dang, yeah the --ota-provider-dir was already present in the previous version, so I did not notice 🙈
That also explains this observation home-assistant/core#123086 (comment):
In addition, I've just installed the 6.4.0 Matter Server update and both the Aqara P2s are still prompting to update to 1.0.1.1.
The softwareVersionValid check was something which got added in 6.4.0.
I'll create a new PR to bump it.
We need to automate this. This is not sustainable. 😢
Bump the Python Matter server to the latest release. Also use the add-on config directory as location for the OTA provider. This allows to see logs and provide local update files for testing and development.
Summary by CodeRabbit