-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samba: correct benign idmap errors #3704
Conversation
WalkthroughWalkthroughThe recent updates to the Samba service primarily address logging improvements and ID mapping configurations. A benign idmap error message has been suppressed to reduce log clutter, enhancing user experience. Additionally, the configuration file has been updated to include a specific ID mapping backend and defined ranges, optimizing user and group ID management within the service. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…ct benign idmap errors
Fixes #3682.
Adds a default idmap to the smb.conf file. This corrects the benign error that was being added to the log for every file access via the Samba add-on.
idmap range not specified for domain '*'
Summary by CodeRabbit
New Features
Bug Fixes
Chores