letsencrypt: do not add dns_gandi_api_key twice

[marcoce7]

Do not add dns_gandi_api_key to /data/dnsapikey, as this is added by /etc/services.d/lets-encrypt/run too. Adding it twice makes certbot fail with
Error parsing credentials configuration '/data/dnsapikey': Duplicate keyword name at line 60.

Summary by CodeRabbit

• Chores

  • Updated configuration file to version 5.0.23.

• Bug Fixes

  • Removed unused configuration setting for dns_gandi_api_key in the setup script.

[home-assistant]

Hi @marcoce7

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[coderabbitai]

Warning

Rate limit exceeded

@marcoce7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 28 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 5f0e70f and 01912d0.

Walkthrough

Walkthrough

This update involves removing the dns_gandi_api_key configuration setting from the file-structure.sh script in the letsencrypt/rootfs/etc/cont-init.d directory and updating the version in the letsencrypt/config.yaml file from 5.0.22 to 5.0.23. These alterations streamline the configuration process and keep the system up-to-date with the latest version.

Changes

File Path	Change Summary
letsencrypt/rootfs/etc/cont-init.d/file-structure.sh	Removed the configuration setting for dns_gandi_api_key
letsencrypt/config.yaml	Updated version from 5.0.22 to 5.0.23

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[marcoce7]

This addresses #3625 and #3649

Stale

[agners]

Thanks for the fix! Can you also bump the version in config.yaml and update CHANGELOG.md.

[marcoce7]

Done.
Currently on the master branch, CHANGELOG.md reports version 5.0.23 but config.yaml is still on 5.0.22.
So I bumped to 5.0.24, I hope this works.

[agners]

So I bumped to 5.0.24, I hope this works.

Ah yeah it seems the bump got missed in #3659. It will cause a rebuild still, so this shouldn't be a problem.