-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
letsencrypt: do not add dns_gandi_api_key twice #3689
Conversation
Do not add dns_gandi_api_key to /data/dnsapikey, as this is added by /etc/services.d/lets-encrypt/run too. Adding it twice makes certbot fail with Error parsing credentials configuration '/data/dnsapikey': Duplicate keyword name at line 60.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Warning Rate limit exceeded@marcoce7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 28 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughWalkthroughThis update involves removing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Thanks for the fix! Can you also bump the version in config.yaml and update CHANGELOG.md. |
Done. |
Ah yeah it seems the bump got missed in #3659. It will cause a rebuild still, so this shouldn't be a problem. |
Do not add dns_gandi_api_key to /data/dnsapikey, as this is added by /etc/services.d/lets-encrypt/run too. Adding it twice makes certbot fail with
Error parsing credentials configuration '/data/dnsapikey': Duplicate keyword name at line 60.
Summary by CodeRabbit
Chores
Bug Fixes
dns_gandi_api_key
in the setup script.