Improve instance reloading, introduce simple worker, add some convenience step functions #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zambrovski
commented
Jul 10, 2024
zambrovski
commented
- adding new step functions
- fix Make sure the assertions on current instance are not using a stale instance but rather retrieve a new one from the runtime #278
- fix provide instance_is_finished_with_endEvent ... #276
- fix allow activityId/taskDefinitionKey on "user_tasks_completes_with_variables" #275
zambrovski
added
Type: enhancement
jangalinski
reviewed
Jul 11, 2024
...sion/src/main/kotlin/io/holunda/camunda/bpm/extension/jgiven/SelfUpdatingInstanceSupplier.kt
Show resolved
Hide resolved
jangalinski
reviewed
Jul 11, 2024
...sion/src/main/kotlin/io/holunda/camunda/bpm/extension/jgiven/SelfUpdatingInstanceSupplier.kt
Outdated
Show resolved
Hide resolved
jangalinski
reviewed
Jul 11, 2024
extension/src/main/kotlin/io/holunda/camunda/bpm/extension/jgiven/ProcessStage.kt
Show resolved
Hide resolved
|
Some remarks/questions ... otherwise, I do not see anything breaking so I would go for a release, and patch if required, can't think of any additional test cases right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.