refactore relation limits to stdClas

holozaen · Dec 20, 2019 · fca058d · fca058d
1 parent 5b16b90
commit fca058d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/.gitignore b/.gitignore
@@ -3,3 +3,4 @@ composer.lock
 /.idea
 /tests/database.sqlite-journal
 /tests/database.sqlite
+/.phpunit.result.cache
diff --git a/src/Models/HasLimitedRelations.php b/src/Models/HasLimitedRelations.php
@@ -5,22 +5,23 @@
 
 
 use OnlineVerkaufen\Subscriptions\Exception\FeatureException;
+use stdClass;
 
 trait HasLimitedRelations
 {
     /**
      * @param string $relation
-     * @return array
+     * @return stdClass
      * @throws FeatureException
      */
-    public function getUsageFor(string $relation): array
+    public function getUsageFor(string $relation): stdClass
     {
         if ($this->$relation) {
             $usedItems = count($this->$relation);
             $availableItems = $this->getFeatureAvailabilityForRelation($relation);
             $remainingItems = $availableItems - $usedItems;
 
-            return [
+            return (object)[
                 'used' => $usedItems,
                 'available' => $availableItems,
                 'remaining' => $remainingItems

diff --git a/tests/unit/HasRestrictedUsagesTraitTest.php b/tests/unit/HasRestrictedUsagesTraitTest.php
@@ -55,11 +55,10 @@ public function can_get_the_usage_stats_for_a_limited_model(): void
             ])
         ]);
         factory(Post::class)->create(['user_id' => $this->user->id]);
-        $this->assertEquals([
-            'used' => 1,
-            'available' => 1,
-            'remaining' => 0
-        ], $this->user->getUsageFor('posts'));
+        $usage = $this->user->getUsageFor('posts');
+        $this->assertEquals(1, $usage->used);
+        $this->assertEquals(1, $usage->available);
+        $this->assertEquals(0, $usage->remaining);
     }
 
     /** @test
@@ -79,11 +78,10 @@ public function can_get_the_usage_stats_for_an_unlimited_model(): void
             ]),
         ]);
         factory(Image::class)->create(['imageable_id' => $this->user->id, 'imageable_type' => User::class]);
-        $this->assertEquals([
-            'used' => 1,
-            'available' => 9999,
-            'remaining' => 9998
-        ], $this->user->getUsageFor('images'));
+        $usage = $this->user->getUsageFor('images');
+        $this->assertEquals(1, $usage->used);
+        $this->assertEquals(9999, $usage->available);
+        $this->assertEquals(9998, $usage->remaining);
     }
 
     /**
@@ -128,20 +126,20 @@ public function can_get_usage_stats_for_all_limited_relations(): void
         factory(Image::class)->create(['imageable_id' => $firstPost->id, 'imageable_type' => Post::class]);
         factory(Image::class)->create(['imageable_id' => $firstPost->id, 'imageable_type' => Post::class]);
         $this->assertEquals([
-            'images' =>  [
+            'images' =>  (object)[
                 'used' => 2,
                 'available' => 2,
                 'remaining' => 0
             ],
-            'posts' => [
+            'posts' => (object)[
                 'used' => 2,
                 'available' => 1,
                 'remaining' => -1
             ]
         ], $this->user->getUsages());
 
         $this->assertEquals([
-            'images' =>  [
+            'images' =>  (object)[
                 'used' => 2,
                 'available' => 9999,
                 'remaining' => 9997