compat: Remove direct dependency on pandas #8236
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
force-pushed
the
compat_nopandas
branch
2 times, most recently
from
ec90fae to
87c744f
Compare
hoxbro
force-pushed
the
compat_nopandas
branch
from
87c744f to
4dbaf90
Compare
|
Great start, though we need to work on removing the dependency in bokeh first. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8236 +/- ##
===========================================
+ Coverage 70.20% 81.75% +11.55%
===========================================
Files 347 348 +1
Lines 54092 54131 +39
===========================================
+ Hits 37973 44255 +6282
+ Misses 16119 9876 -6243 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philippjfr
reviewed
Oct 29, 2025
| assert location.search == "?dataframe=%5B%7B%22x%22%3A+1%7D%5D" | ||
|
|
||
| def test_location_sync_to_dataframe(location, dataframe): | ||
| pd = pytest.importorskip("pandas") |
There was a problem hiding this comment.
Can we convert these to decorators, i.e.:
pd_available = pytest.mark.skipif(pd is None, reason="requires pandas")
There was a problem hiding this comment.
Sure, will do this before a merge. For now this is easier to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really early. This is to test-run our testsuite without having Pandas as a direct dependency.