Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ibis histogram #5531

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
refactor
MarcSkovMadsen committed Nov 29, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit ddaeb3daa6b78dc164e928687d93c509b41255de
5 changes: 3 additions & 2 deletions holoviews/core/data/ibis.py
Original file line number Diff line number Diff line change
@@ -111,13 +111,14 @@ def nonzero(cls, dataset):
@cached
def range(cls, dataset, dimension):
dimension = dataset.get_dimension(dimension, strict=True)
if cls.dtype(dataset, dimension).kind == 'O':
dtype_kind = cls.dtype(dataset, dimension).kind
if dtype_kind == 'O':
# Can this be done more efficiently?
column = dataset.data[dimension.name].execute()
first = column.iloc[0]
last = column.iloc[-1]
return first, last
if cls.dtype(dataset, dimension).kind in 'SU':
if dtype_kind in 'SU':
return None, None
if dimension.nodata is not None:
return Interface.range(dataset, dimension)