Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/icons #92

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feat/icons #92

wants to merge 9 commits into from

Conversation

fabiangaukler
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: 2ea4450

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@holisticon/hap-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fabiangaukler fabiangaukler marked this pull request as draft January 14, 2025 08:27
@fabiangaukler fabiangaukler force-pushed the feat/icons branch 2 times, most recently from 93d797a to acc1307 Compare February 7, 2025 12:01
@fabiangaukler fabiangaukler marked this pull request as ready for review February 7, 2025 13:07
<i data-lucide="download"></i>
<i data-lucide="lock"></i>
</div>`,
play: (args) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the play methods in the button and icon stories still needed when lucide is initialized during preview?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case yes because we need to adjust the size and the color of the icon for the showcase in the stories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants