Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative tolerance #215

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

nightscape
Copy link
Contributor

@nightscape nightscape commented Nov 9, 2017

Fixes #214

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #215 into master will decrease coverage by 78.35%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #215       +/-   ##
=========================================
- Coverage   78.35%     0%   -78.36%     
=========================================
  Files          45     34       -11     
  Lines         388     34      -354     
  Branches       34      1       -33     
=========================================
- Hits          304      0      -304     
+ Misses         63     34       -29     
+ Partials       21      0       -21
Flag Coverage Δ
#python ?
#scala 0% <0%> (ø) ⬆️
Impacted Files Coverage Δ
...holdenkarau/spark/testing/DataFrameSuiteBase.scala 0% <0%> (ø) ⬆️
sparktestingbase/test/reuse_spark_context_test.py
sparktestingbase/streamingtestcase.py
sparktestingbase/test/simple_sql_test.py
sparktestingbase/sqltestcase.py
sparktestingbase/test/helloworld_test.py
sparktestingbase/test/simple_test.py
sparktestingbase/utils.py
sparktestingbase/test/simple_streaming_test.py
sparktestingbase/testcase.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79eef40...c2bc44c. Read the comment docs.

@nightscape nightscape force-pushed the relative_tolerance branch 2 times, most recently from 1236c8f to c6ac5d3 Compare November 9, 2017 13:22
@nightscape nightscape changed the title Relative tolerance Relative tolerance. Fixes #214 Nov 9, 2017
@nightscape nightscape changed the title Relative tolerance. Fixes #214 Relative tolerance Nov 9, 2017
@nightscape
Copy link
Contributor Author

Hey @holdenk,

we've got a working version and have successfully tested it in one of our projects.
Would you mind having a look and tell me if you want me to do anything about the codacy/pr and codecov/patch failures?

@holdenk
Copy link
Owner

holdenk commented Nov 25, 2017

I wouldn't worry too much about codecov/patch, codecov has and cross-version Spark gets a little confused. If you've got the time to address some of the usggestions from codacy that would maybe be useful.

@holdenk
Copy link
Owner

holdenk commented Jan 11, 2018

Gentle ping, we're considering releasing a new version soon/ If you could address some of the codacy issues it would be awesome to get this in.

@nightscape
Copy link
Contributor Author

Hi @holdenk,

as noted on the other issue I won't have time to do much coding in the next time.
I can continue to work on this in ~3 weeks when I'm back from my parenting vacation.

Best
Martin

@holdenk
Copy link
Owner

holdenk commented Jul 1, 2018

Gentle ping sorry it's been so long.

@nightscape nightscape force-pushed the relative_tolerance branch 2 times, most recently from ded278c to 6433b08 Compare December 29, 2019 02:24
@nightscape nightscape force-pushed the relative_tolerance branch 2 times, most recently from 3cff924 to 474f113 Compare December 29, 2019 02:32
@nightscape nightscape force-pushed the relative_tolerance branch 2 times, most recently from b181d35 to 6916fe0 Compare December 30, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

approxEquals with relative tolerance
3 participants