-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative tolerance #215
base: main
Are you sure you want to change the base?
Relative tolerance #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
- Coverage 78.35% 0% -78.36%
=========================================
Files 45 34 -11
Lines 388 34 -354
Branches 34 1 -33
=========================================
- Hits 304 0 -304
+ Misses 63 34 -29
+ Partials 21 0 -21
Continue to review full report at Codecov.
|
1236c8f
to
c6ac5d3
Compare
Hey @holdenk, we've got a working version and have successfully tested it in one of our projects. |
I wouldn't worry too much about codecov/patch, codecov has and cross-version Spark gets a little confused. If you've got the time to address some of the usggestions from codacy that would maybe be useful. |
Gentle ping, we're considering releasing a new version soon/ If you could address some of the codacy issues it would be awesome to get this in. |
Hi @holdenk, as noted on the other issue I won't have time to do much coding in the next time. Best |
Gentle ping sorry it's been so long. |
c6ac5d3
to
88c71af
Compare
88c71af
to
7c08947
Compare
ded278c
to
6433b08
Compare
3cff924
to
474f113
Compare
b181d35
to
6916fe0
Compare
6916fe0
to
c2bc44c
Compare
Fixes #214