Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch mint's collection #200

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Switch mint's collection #200

merged 4 commits into from
Aug 28, 2023

Conversation

imabdulbasit
Copy link
Contributor

No description provided.

@imabdulbasit
Copy link
Contributor Author

add a check for new.collection != existing collection

kespinola
kespinola requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you close out the PR by adding a field on CollectionMint that is switch_collection_histories that looks up the any switch records for the collection mint using a data loader?

Looks good though. Thank you.

api/src/mutations/collection.rs Show resolved Hide resolved
api/src/mutations/collection.rs Outdated Show resolved Hide resolved
@imabdulbasit imabdulbasit marked this pull request as draft August 28, 2023 13:48
@imabdulbasit imabdulbasit force-pushed the abdul/switch-collection branch 2 times, most recently from 62aa89a to 785d1ce Compare August 28, 2023 14:13
@imabdulbasit imabdulbasit marked this pull request as ready for review August 28, 2023 14:22
@imabdulbasit imabdulbasit merged commit 958d2db into main Aug 28, 2023
4 checks passed
@imabdulbasit imabdulbasit deleted the abdul/switch-collection branch August 28, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kespinola kespinola kespinola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imabdulbasit @kespinola @mpwsh