Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections Api New #140

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Collections Api New #140

merged 5 commits into from
Jul 18, 2023

Conversation

alchemistgo87
Copy link
Contributor

No description provided.

@alchemistgo87 alchemistgo87 marked this pull request as ready for review July 17, 2023 14:33
Copy link
Contributor

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the one adjustment and run cargo fmt.

Comment on lines 45 to 47
collection.ok_or_else(|| {
FieldError::new(format!("no collection for the drop {}", drop.id))
})?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
collection.ok_or_else(|| {
FieldError::new(format!("no collection for the drop {}", drop.id))
})?,
collection.ok_or(
FieldError::new(format!("no collection for the drop {}", drop.id))
)?,

@kespinola kespinola merged commit a7fa3fd into espi/1-of-1-mints Jul 18, 2023
4 checks passed
@kespinola kespinola deleted the anshul/collections-api branch July 18, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants