Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced dependencies (broom, dplyr, magrittr) with lighter alternatives #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mariusbarth
Copy link

Hi @hojsgaard,

thank you for this awesome package! While reading your source code, I figured that it would be quiet easy to drop some dependencies to other R packages, which will result in a more lightweight dependency graph for other R packages (especially afex).

  • I replaced broom with generics, because the tidy() generic from the generics package can be safely used, and generics is much more lightweight (and also an import of broom).
  • I replaced dplyr with tibble, because as_tibble() can be used from there, and tibble is more lightweight than dplyr (and also an import of dplyr).
  • I removed magrittr, because it was only imported to reexport the pipe operator, but users can now use the base-R pipe.

I really hope you like these changes, because it will help me prune my dependency graphs, especially on my CI. Hope I didn't miss anything, and looking forward to your feedback!

Kind regards,
Marius

@mariusbarth mariusbarth changed the title replaced dependencies (broom, dplyr, magrittr) to lighter alternatives replaced dependencies (broom, dplyr, magrittr) with lighter alternatives Sep 30, 2021
@crsh
Copy link

crsh commented Feb 16, 2024

I'm also interested in this. These change would nicely trim the dependency tree on some of my R packages and speed up the CI pipeline for testing the packages. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants