Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alt display names to always be pango #519

Open
wants to merge 5 commits into
base: 424-add-toggle-to-switch-between-pango-and-nextclade-nomenclature
Choose a base branch
from

Conversation

emmahodcroft
Copy link
Collaborator

Updates so that alt_display_name is always the Pango lineage, to make this an easy 'alternative' for dispalying instead of the Nextclade name!

@AdvancedCodingMonkey
Copy link
Collaborator

Thanks for the update @emmahodcroft , these variants seem to have no alt_display_name at all but they have pango lineages. Could you update those as well?

  • 21I (Delta)
  • 21J (Delta)
  • 21G (Lambda)
  • 21H (Mu)
  • 20B/S:732A
  • 20A/S:126A
  • 20A/S:439K
  • 20A.EU2
  • 20A/S:98F
  • 20A/S:439K
  • 20C/S:80Y
  • 20B/S:626S
  • 20B/S:1122L
    Also: 20A.EU2 does not seem to have a nextclade name (shouldn't it be 20E (EU2?). If so, could you update the display_name field for this variant as well?

@AdvancedCodingMonkey AdvancedCodingMonkey linked an issue Feb 20, 2025 that may be closed by this pull request
@AdvancedCodingMonkey AdvancedCodingMonkey changed the base branch from master to 424-add-toggle-to-switch-between-pango-and-nextclade-nomenclature February 20, 2025 15:18
@emmahodcroft
Copy link
Collaborator Author

Also: 20A.EU2 does not seem to have a nextclade name (shouldn't it be 20E (EU2?). If so, could you update the display_name field for this variant as well?

Unfortunately 20A.EU2 doesn't have an official Nextclade designation. Is the issue just that the name isn't fitting a format needed for display, or is there a deeper issue at play?

@emmahodcroft emmahodcroft temporarily deployed to refs/heads/staging March 6, 2025 17:14 — with GitHub Actions Inactive
@emmahodcroft emmahodcroft deployed to refs/heads/staging March 7, 2025 17:07 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update alt_display_names for old variants
2 participants