Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Added Language configuration setting - #119 #130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbronk
Copy link

@mbronk mbronk commented May 2, 2021

Added (naive) language configuration option into settings dialog
++ few missing translations (by far not an exhaustive translation)

@cloom
Copy link

cloom commented Oct 1, 2022

Hello @mbronk

Any luck trying to clear the errors? I am not familiar with the tool but the logs are not loading:
https://travis-ci.org/github/hobbyquaker/homematic-manager/jobs/769231563

@hobbyquaker any pointers? That would be very appreciated to have some English in this very useful tool you made!

Thank you

@mbronk
Copy link
Author

mbronk commented Oct 1, 2022

Hi @cloom ,

I've completely forgotten about this PR, actually... :)
Since it's been well over a year, I suspect Travis cleanup policies may be causing the build logs not to show up...
Let me try to get it to re-build to see if it is anything trivial.


Unfortunately though, I have stopped using this project a long while ago, and don't even recall where I had my dev env set up, so am unlikely to be able to do any major changes to get the CI happy. To be honest, I should have abandoned this PR a while ago, but... forgot to do so.
You're more than welcome to pick up based off of my branch (not sure what the CI error was, but I believe it did compile at the time I pushed it).

Let me force push an empty change to get the PR to rebuild.

Cheers!

@mbronk
Copy link
Author

mbronk commented Oct 1, 2022

Well... I'm afraid the CI has been long set to read-only mode and isn't too cooperative.
I'd guess you'll need help from @hobbyquaker to get it run.

BTW. I don't recall any more, but would guess the build failure on Mac was random (there's nothing I see in the PR which seems suspect to work on amd64 but fail for mac)... Aka. if you have node/electron set up... I suggest you try to compile it locally.

Added (naive) language configuration option into settings dialog
 ++ few missing translations (by far not an exhaustive translation)
@hobbyquaker
Copy link
Owner

Hi! Thanks for the PR!

Will try to find time to migrate the build to github actions, but can't promise when...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants