Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Set header buffer size #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pierozi
Copy link
Member

@Pierozi Pierozi commented Aug 12, 2016

Refer to #73

This first proposal are implement with set method.
Implement by Zformat seems to me bit excessive for the case.
We should also define as a constructor argument, but like in future we plane to make this auto detected by Hoa\Http. Is not suitable to change the constructor interface.

@Hywan
Copy link
Member

Hywan commented Aug 15, 2016

Discussion happens in #73.

Server.php Outdated
*
* @var int
*/
protected $headerLength = 2048;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #73, remove this.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these modifications, we will solve most of the issue while redesigning the Hoa\Http library.

Server.php Outdated
* @param int $length
* @return void
*/
public function setHeaderBufferSize($length)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #73, remove this.

Server.php Outdated
@@ -89,7 +106,7 @@ public function __construct(
protected function doHandshake()
{
$connection = $this->getConnection();
$buffer = $connection->read(2048);
$buffer = $connection->read($this->headerLength);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #73, just increase to 4096.

@Pierozi Pierozi assigned Pierozi and unassigned Hywan Mar 31, 2017
remove setter header buffer size and hardcode 4096bytes
@coveralls
Copy link

coveralls commented Nov 1, 2017

Coverage Status

Coverage remained the same at 86.545% when pulling 4fd4e5d on Pierozi:feature/bufferSize into a2a5964 on hoaproject:master.

@Pierozi
Copy link
Member Author

Pierozi commented Nov 23, 2017

ping @Hywan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants