Skip to content

Commit 0667134

Browse files
authored
Fix typo in luma texture format for Float32Array (r32float) (#868)
* Fix typo in luma texture format for Float32Array (`r32float`) * update ubuntu * try fix xfvb * try macos
1 parent e1050fc commit 0667134

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

.changeset/twelve-flowers-beam.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@vivjs/constants": patch
3+
---
4+
5+
Fix typo in luma texture format for Float32Array (`r32float`)

.github/workflows/ci.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,10 @@ jobs:
3131
- run: biome ci .
3232

3333
Test:
34-
runs-on: ubuntu-20.04
35-
env:
36-
DISPLAY: :0
34+
runs-on: macos-latest
3735
steps:
3836
- uses: actions/checkout@v4
3937
- uses: pnpm/action-setup@v4
4038
with:
4139
run_install: true
42-
43-
- name: Setup xvf (Linux)
44-
if: runner.os == 'Linux'
45-
run: |
46-
sudo apt-get install -y xvfb
47-
# start xvfb in the background
48-
sudo /usr/bin/Xvfb $DISPLAY -screen 0 1280x1024x24 &
49-
5040
- run: pnpm test

packages/constants/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export const DTYPE_VALUES = {
7070
},
7171
// Cast Float64 as 32 bit float point so it can be rendered.
7272
Float64: {
73-
format: 'r32sfloat',
73+
format: 'r32float',
7474
dataFormat: GL.RED,
7575
type: GL.FLOAT,
7676
// Not sure what to do about this one - a good use case for channel stats, I suppose:

0 commit comments

Comments
 (0)