Add DTO-based optimization for Category Day End Report#18384
Open
buddhika75 wants to merge 3 commits intodevelopmentfrom
Open
Add DTO-based optimization for Category Day End Report#18384buddhika75 wants to merge 3 commits intodevelopmentfrom
buddhika75 wants to merge 3 commits intodevelopmentfrom
Conversation
This commit resolves performance issues and timeouts in the By Category Day End Report by implementing DTO-based database queries instead of entity-based queries. Changes: - Created CategoryDayEndReportDto class for optimized data transfer - Added createCashCategoryWithProDayDto() method in BookKeepingSummery controller with DTO-based query methods - Created new JSF page report_cash_category_with_pro_day_dto.xhtml for the optimized report - Added green button in navigation (report_own.xhtml) to access the new DTO-optimized report - Kept old entity-based methods intact for backward compatibility and comparison The DTO approach uses aggregated JPQL queries that fetch only necessary data, significantly reducing memory usage and execution time compared to loading full entity objects. Closes #18380 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
WalkthroughAdds a DTO-based Category Day End reporting path: new DTO class, new DTO-driven workflow and helpers in the BookKeepingSummery bean, a DTO-optimized JSF view, and a navigation button; preserves existing entity-based reporting for compatibility. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User/UI
participant Bean as BookKeepingSummery
participant DB as Database/Query Layer
participant View as JSF View
User->>Bean: invoke createCashCategoryWithProDayDto()
activate Bean
Bean->>Bean: initialize DTO lists & validate dates
Bean->>DB: fetchOpdCollectionsByPaymentMethodDto(...)
DB-->>Bean: OPD DTO lists
Bean->>DB: fetchPharmacyCollectionsDto(...)
DB-->>Bean: Pharmacy DTO lists
Bean->>DB: fetchChannelCollectionsDto(...)
DB-->>Bean: Channel DTO lists
Bean->>DB: fetchInwardCollectionsDto(...)
DB-->>Bean: Inward DTO lists
Bean->>Bean: calculateDtoTotal() per cohort & grandDtoTotal
deactivate Bean
User->>View: request/render DTO-optimized report
View->>Bean: read DTO lists & totals
View-->>User: render tables and grand summary
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Changed from findByJpql to findLightsByJpql with explicit casting to List<CategoryDayEndReportDto> for all DTO fetch methods to resolve type incompatibility errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@src/main/java/com/divudi/bean/report/BookKeepingSummery.java`:
- Around line 4531-4544: The JPQL in the jpql variable builds
CategoryDayEndReportDto by joining Bill b to b.billItems bi, which causes
SUM(b.netTotal) and COUNT(b.id) to be inflated; fix by aggregating at the bill
level or using distinct counts: either remove the LEFT JOIN b.billItems bi and
group by bi.item.category via a subquery on Bill (so SUM(b.netTotal) remains
correct), or keep the join but change the aggregates to SUM(b.netTotal) with
COUNT(DISTINCT b.id) (and/or SUM(DISTINCT b.netTotal) if needed) and ensure
GROUP BY uses c.name; update the query that constructs new
com.divudi.core.data.dto.CategoryDayEndReportDto accordingly.
In
`@src/main/webapp/reportInstitution/report_cash_category_with_pro_day_dto.xhtml`:
- Line 69: Replace raw HTML heading tags with JSF output components: find each
occurrence of the <h3> heading text (e.g., the string "OPD Cash Collections
(Cash, Card, Cheque, Slip)" and the other headings referenced) and replace the
<h3> element with an h:outputText (or p:outputLabel) using the same heading text
as the value and, if needed, a styleClass for visual styling (for example:
h:outputText value="OPD Cash Collections (Cash, Card, Cheque, Slip)"
styleClass="section-heading"). Do this for the heading instances mentioned (the
one with the OPD label and the other headings at the noted locations) so XHTML
markup uses JSF components instead of raw <h3> tags.
- Around line 20-34: The labels are not associated with their inputs and
controls lack accessible tooltips; update each h:outputLabel to include
for="frmDate" and for="toDate" (matching the p:calendar ids) and add descriptive
title and aria-label attributes to the p:calendar components (ids frmDate and
toDate) and the p:autoComplete (value #{bookKeepingSummery.institution},
completeMethod #{institutionController.completeCompany}) so screen-readers and
tooltips can announce purpose; ensure forceSelection/requiredMessage remain and
that itemLabel/itemValue are preserved for p:autoComplete.
- Around line 249-260: The p:dataTable with id "summaryTable" is missing
required attributes value and var so it won't render; either bind it to a
one-element list or DTO in the backing bean (e.g., provide List or array on the
bean used by report, and set value="#{bookKeepingSummery.someSummaryList}"
var="summary" and then reference summary.grandDtoTotal) or replace the table
with a non-iterative component such as <p:panelGrid> or plain <h:panelGroup> and
render the value via #{bookKeepingSummery.grandDtoTotal}; also remove or update
any exporter targets that reference "summaryTable" to point to the new component
or include the list-based table.
🧹 Nitpick comments (1)
src/main/java/com/divudi/core/data/dto/CategoryDayEndReportDto.java (1)
13-115: UseDoublewrappers for monetary fields in this DTO.Primitives prevent representing missing aggregates and can throw on unboxing when JPQL returns nulls. Switching to
Doublepreserves null semantics and avoids NPEs.♻️ Suggested change
- private double cashValue; - private double creditValue; - private double totalValue; + private Double cashValue; + private Double creditValue; + private Double totalValue; @@ - public CategoryDayEndReportDto(String categoryName, String subCategoryName, - double cashValue, double creditValue, long billCount) { + public CategoryDayEndReportDto(String categoryName, String subCategoryName, + Double cashValue, Double creditValue, long billCount) { @@ - this.totalValue = cashValue + creditValue; + this.totalValue = (cashValue == null && creditValue == null) + ? null + : (cashValue == null ? 0d : cashValue) + (creditValue == null ? 0d : creditValue);Based on learnings: For DTO/Light classes like BillLight, use Double wrapper types instead of primitive double for monetary fields (ccTotal, hospitalTotal, etc.) to preserve semantic information about missing/undefined values.
Comment on lines
20
to
34
| <h:panelGrid columns="2" class="my-2" > | ||
| <h:outputLabel value="From Date"/> | ||
| <p:calendar class="w-100 mx-4" inputStyleClass="w-100" id="frmDate" value="#{bookKeepingSummery.fromDate}" pattern="dd MM yyyy HH:mm:ss" > | ||
| </p:calendar> | ||
|
|
||
| <h:outputLabel value="To Date"/> | ||
| <p:calendar class="w-100 mx-4" inputStyleClass="w-100 my-1" id="toDate" value="#{bookKeepingSummery.toDate}" pattern="dd MM yyyy HH:mm:ss" > | ||
| </p:calendar> | ||
|
|
||
| <h:outputLabel value="Select Institution"/> | ||
|
|
||
| <p:autoComplete class="w-100 mx-4" inputStyleClass="w-100" completeMethod="#{institutionController.completeCompany}" required="true" | ||
| forceSelection="true" | ||
| requiredMessage="Please Select Institution" value="#{bookKeepingSummery.institution}" | ||
| var="pta" itemLabel="#{pta.name}" itemValue="#{pta}" /> |
Contributor
There was a problem hiding this comment.
Associate labels with inputs and add tooltips for accessibility.
h:outputLabel should reference the input IDs, and interactive controls should expose titles/aria-labels.
🧭 Suggested fix
- <h:outputLabel value="From Date"/>
+ <h:outputLabel for="frmDate" value="From Date"/>
@@
- <p:calendar class="w-100 mx-4" inputStyleClass="w-100" id="frmDate" value="#{bookKeepingSummery.fromDate}" pattern="dd MM yyyy HH:mm:ss" >
+ <p:calendar class="w-100 mx-4" inputStyleClass="w-100" id="frmDate" value="#{bookKeepingSummery.fromDate}" pattern="dd MM yyyy HH:mm:ss"
+ ariaLabel="From Date">As per coding guidelines: Implement accessibility with proper tooltips and labeling.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <h:panelGrid columns="2" class="my-2" > | |
| <h:outputLabel value="From Date"/> | |
| <p:calendar class="w-100 mx-4" inputStyleClass="w-100" id="frmDate" value="#{bookKeepingSummery.fromDate}" pattern="dd MM yyyy HH:mm:ss" > | |
| </p:calendar> | |
| <h:outputLabel value="To Date"/> | |
| <p:calendar class="w-100 mx-4" inputStyleClass="w-100 my-1" id="toDate" value="#{bookKeepingSummery.toDate}" pattern="dd MM yyyy HH:mm:ss" > | |
| </p:calendar> | |
| <h:outputLabel value="Select Institution"/> | |
| <p:autoComplete class="w-100 mx-4" inputStyleClass="w-100" completeMethod="#{institutionController.completeCompany}" required="true" | |
| forceSelection="true" | |
| requiredMessage="Please Select Institution" value="#{bookKeepingSummery.institution}" | |
| var="pta" itemLabel="#{pta.name}" itemValue="#{pta}" /> | |
| <h:panelGrid columns="2" class="my-2" > | |
| <h:outputLabel for="frmDate" value="From Date"/> | |
| <p:calendar class="w-100 mx-4" inputStyleClass="w-100" id="frmDate" value="#{bookKeepingSummery.fromDate}" pattern="dd MM yyyy HH:mm:ss" | |
| ariaLabel="From Date"> | |
| </p:calendar> | |
| <h:outputLabel value="To Date"/> | |
| <p:calendar class="w-100 mx-4" inputStyleClass="w-100 my-1" id="toDate" value="#{bookKeepingSummery.toDate}" pattern="dd MM yyyy HH:mm:ss" > | |
| </p:calendar> | |
| <h:outputLabel value="Select Institution"/> | |
| <p:autoComplete class="w-100 mx-4" inputStyleClass="w-100" completeMethod="#{institutionController.completeCompany}" required="true" | |
| forceSelection="true" | |
| requiredMessage="Please Select Institution" value="#{bookKeepingSummery.institution}" | |
| var="pta" itemLabel="#{pta.name}" itemValue="#{pta}" /> |
🤖 Prompt for AI Agents
In
`@src/main/webapp/reportInstitution/report_cash_category_with_pro_day_dto.xhtml`
around lines 20 - 34, The labels are not associated with their inputs and
controls lack accessible tooltips; update each h:outputLabel to include
for="frmDate" and for="toDate" (matching the p:calendar ids) and add descriptive
title and aria-label attributes to the p:calendar components (ids frmDate and
toDate) and the p:autoComplete (value #{bookKeepingSummery.institution},
completeMethod #{institutionController.completeCompany}) so screen-readers and
tooltips can announce purpose; ensure forceSelection/requiredMessage remain and
that itemLabel/itemValue are preserved for p:autoComplete.
src/main/webapp/reportInstitution/report_cash_category_with_pro_day_dto.xhtml
Outdated
Show resolved
Hide resolved
src/main/webapp/reportInstitution/report_cash_category_with_pro_day_dto.xhtml
Outdated
Show resolved
Hide resolved
- Fix channel query overcounting: use SUM(bi.netValue) and COUNT(DISTINCT b.id) instead of SUM(b.netTotal) and COUNT(b.id) which were inflated by bill items join - Replace empty p:dataTable (summaryTable) with p:panelGrid since it has no value/var and won't render; remove from dataExporter targets - Replace raw <h3> HTML tags with h:outputText JSF components for consistency - Add for attributes to h:outputLabel for form accessibility Closes #18380 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/main/java/com/divudi/bean/report/BookKeepingSummery.java`:
- Around line 4454-4577: The DTO JPQL queries in
fetchOpdCollectionsByPaymentMethodDto, fetchPharmacyCollectionsDto,
fetchChannelCollectionsDto, and fetchInwardCollectionsDto omit filtering retired
BillItem rows, causing inflated sums/counts; update each JPQL string to include
"AND bi.retired = false" in the WHERE clause (alongside the existing b.retired =
false) so retired bill items are excluded, then run tests/compare with legacy
report results to verify counts match.
In
`@src/main/webapp/reportInstitution/report_cash_category_with_pro_day_dto.xhtml`:
- Around line 39-55: The report action buttons (p:commandButton invoking
bookKeepingSummery.createCashCategoryWithProDayDto and the Print/Excel/Compare
buttons) lack UI privilege guards; wrap each actionable button with a rendered
(or disabled) attribute that calls webUserController.hasPrivilege(...) using the
same privilege keys used by other report pages (e.g., the pattern "REPORT_*" or
the specific privilege used for the comparable report page) so only authorized
users see/activate them; apply this to the Process button (action
bookKeepingSummery.createCashCategoryWithProDayDto), the Print (p:printer
target="panelPrint"), Excel (p:dataExporter target=...), and Compare
(action="report_cash_category_with_pro_day") controls, mirroring the existing
pages' use of webUserController.hasPrivilege() for rendered/disabled.
Comment on lines
+4454
to
+4577
| private List<CategoryDayEndReportDto> fetchOpdCollectionsByPaymentMethodDto(List<PaymentMethod> paymentMethods) { | ||
| List<CategoryDayEndReportDto> dtoList = new ArrayList<>(); | ||
|
|
||
| if (institution == null || fromDate == null || toDate == null) { | ||
| return dtoList; | ||
| } | ||
|
|
||
| String jpql = "SELECT NEW com.divudi.core.data.dto.CategoryDayEndReportDto(" | ||
| + "COALESCE(c.name, 'No Category'), " | ||
| + "SUM(bi.netValue), " | ||
| + "COUNT(DISTINCT b.id)) " | ||
| + "FROM BillItem bi JOIN bi.bill b " | ||
| + "LEFT JOIN bi.item.category c " | ||
| + "WHERE b.billType IN :billTypes " | ||
| + "AND b.institution = :ins " | ||
| + "AND b.createdAt BETWEEN :fd AND :td " | ||
| + "AND b.paymentMethod IN :pm " | ||
| + "AND b.retired = false " | ||
| + "GROUP BY c.name " | ||
| + "ORDER BY c.name"; | ||
|
|
||
| Map<String, Object> params = new HashMap<>(); | ||
| params.put("billTypes", Arrays.asList(BillType.OpdBill)); | ||
| params.put("ins", institution); | ||
| params.put("fd", fromDate); | ||
| params.put("td", toDate); | ||
| params.put("pm", paymentMethods); | ||
|
|
||
| dtoList = (List<CategoryDayEndReportDto>) billFacade.findLightsByJpql(jpql, params, TemporalType.TIMESTAMP); | ||
|
|
||
| return dtoList == null ? new ArrayList<>() : dtoList; | ||
| } | ||
|
|
||
| /** | ||
| * Fetch pharmacy collections grouped by category using DTO | ||
| */ | ||
| private List<CategoryDayEndReportDto> fetchPharmacyCollectionsDto(BillType billType) { | ||
| List<CategoryDayEndReportDto> dtoList = new ArrayList<>(); | ||
|
|
||
| if (institution == null || fromDate == null || toDate == null) { | ||
| return dtoList; | ||
| } | ||
|
|
||
| String jpql = "SELECT NEW com.divudi.core.data.dto.CategoryDayEndReportDto(" | ||
| + "COALESCE(c.name, 'No Category'), " | ||
| + "SUM(bi.netValue), " | ||
| + "COUNT(DISTINCT b.id)) " | ||
| + "FROM BillItem bi JOIN bi.bill b " | ||
| + "LEFT JOIN bi.item.category c " | ||
| + "WHERE b.billType = :bt " | ||
| + "AND b.institution = :ins " | ||
| + "AND b.createdAt BETWEEN :fd AND :td " | ||
| + "AND b.retired = false " | ||
| + "GROUP BY c.name " | ||
| + "ORDER BY c.name"; | ||
|
|
||
| Map<String, Object> params = new HashMap<>(); | ||
| params.put("bt", billType); | ||
| params.put("ins", institution); | ||
| params.put("fd", fromDate); | ||
| params.put("td", toDate); | ||
|
|
||
| dtoList = (List<CategoryDayEndReportDto>) billFacade.findLightsByJpql(jpql, params, TemporalType.TIMESTAMP); | ||
|
|
||
| return dtoList == null ? new ArrayList<>() : dtoList; | ||
| } | ||
|
|
||
| /** | ||
| * Fetch channel collections grouped by category using DTO | ||
| */ | ||
| private List<CategoryDayEndReportDto> fetchChannelCollectionsDto() { | ||
| List<CategoryDayEndReportDto> dtoList = new ArrayList<>(); | ||
|
|
||
| if (institution == null || fromDate == null || toDate == null) { | ||
| return dtoList; | ||
| } | ||
|
|
||
| String jpql = "SELECT NEW com.divudi.core.data.dto.CategoryDayEndReportDto(" | ||
| + "COALESCE(c.name, 'Channel'), " | ||
| + "SUM(bi.netValue), " | ||
| + "COUNT(DISTINCT b.id)) " | ||
| + "FROM BillItem bi JOIN bi.bill b " | ||
| + "LEFT JOIN bi.item.category c " | ||
| + "WHERE b.billType IN :billTypes " | ||
| + "AND b.institution = :ins " | ||
| + "AND b.createdAt BETWEEN :fd AND :td " | ||
| + "AND b.retired = false " | ||
| + "GROUP BY c.name " | ||
| + "ORDER BY c.name"; | ||
|
|
||
| Map<String, Object> params = new HashMap<>(); | ||
| params.put("billTypes", Arrays.asList(BillType.ChannelCash, BillType.ChannelAgent, BillType.ChannelPaid)); | ||
| params.put("ins", institution); | ||
| params.put("fd", fromDate); | ||
| params.put("td", toDate); | ||
|
|
||
| dtoList = (List<CategoryDayEndReportDto>) billFacade.findLightsByJpql(jpql, params, TemporalType.TIMESTAMP); | ||
|
|
||
| return dtoList == null ? new ArrayList<>() : dtoList; | ||
| } | ||
|
|
||
| /** | ||
| * Fetch inward collections grouped by category using DTO | ||
| */ | ||
| private List<CategoryDayEndReportDto> fetchInwardCollectionsDto() { | ||
| List<CategoryDayEndReportDto> dtoList = new ArrayList<>(); | ||
|
|
||
| if (institution == null || fromDate == null || toDate == null) { | ||
| return dtoList; | ||
| } | ||
|
|
||
| String jpql = "SELECT NEW com.divudi.core.data.dto.CategoryDayEndReportDto(" | ||
| + "COALESCE(c.name, 'Inward'), " | ||
| + "SUM(bi.netValue), " | ||
| + "COUNT(DISTINCT b.id)) " | ||
| + "FROM BillItem bi JOIN bi.bill b " | ||
| + "LEFT JOIN bi.item.category c " | ||
| + "WHERE b.billType IN :billTypes " | ||
| + "AND b.institution = :ins " | ||
| + "AND b.createdAt BETWEEN :fd AND :td " | ||
| + "AND b.retired = false " | ||
| + "GROUP BY c.name " | ||
| + "ORDER BY c.name"; | ||
|
|
Contributor
There was a problem hiding this comment.
Exclude retired BillItems in DTO aggregations.
The DTO queries filter b.retired but not bi.retired, so retired bill items can still be counted. This can inflate totals and bill counts versus the legacy report queries that exclude retired items. Add AND bi.retired = false to all DTO JPQL strings (OPD, pharmacy, channel, inward).
🔧 Example fix (apply to all DTO JPQL builders)
- + "AND b.retired = false "
+ + "AND b.retired = false "
+ + "AND bi.retired = false "🤖 Prompt for AI Agents
In `@src/main/java/com/divudi/bean/report/BookKeepingSummery.java` around lines
4454 - 4577, The DTO JPQL queries in fetchOpdCollectionsByPaymentMethodDto,
fetchPharmacyCollectionsDto, fetchChannelCollectionsDto, and
fetchInwardCollectionsDto omit filtering retired BillItem rows, causing inflated
sums/counts; update each JPQL string to include "AND bi.retired = false" in the
WHERE clause (alongside the existing b.retired = false) so retired bill items
are excluded, then run tests/compare with legacy report results to verify counts
match.
Comment on lines
+39
to
+55
| <p:commandButton value="Process" ajax="false" class="ui-button-warning" icon="fas fa-cogs" | ||
| action="#{bookKeepingSummery.createCashCategoryWithProDayDto}"/> | ||
| <p:commandButton ajax="false" value="Print" class="ui-button-info mx-2" icon="fas fa-print" > | ||
| <p:printer target="panelPrint" /> | ||
| </p:commandButton> | ||
| <p:commandButton value="Excel" ajax="false" class="ui-button-success" icon="fas fa-file-excel" > | ||
| <p:dataExporter type="xlsx" target="opdCashTable, | ||
| opdCreditTable, | ||
| pharmacySalesTable, | ||
| pharmacyWholeSalesTable, | ||
| channelTable, | ||
| inwardTable" | ||
| fileName="Book_Keeping_Summery_with_pro_day_dto" | ||
| /> | ||
| </p:commandButton> | ||
| <p:commandButton value="Compare with Old Version" ajax="false" class="ui-button-secondary" icon="fas fa-balance-scale" | ||
| action="report_cash_category_with_pro_day"/> |
Contributor
There was a problem hiding this comment.
Gate report actions with privilege checks.
The new report actions are exposed without webUserController.hasPrivilege() checks. Please align with existing report pages and add privilege-based rendered/disabled guards for these actions.
As per coding guidelines, Use webUserController.hasPrivilege() for UI privilege integration.
🤖 Prompt for AI Agents
In
`@src/main/webapp/reportInstitution/report_cash_category_with_pro_day_dto.xhtml`
around lines 39 - 55, The report action buttons (p:commandButton invoking
bookKeepingSummery.createCashCategoryWithProDayDto and the Print/Excel/Compare
buttons) lack UI privilege guards; wrap each actionable button with a rendered
(or disabled) attribute that calls webUserController.hasPrivilege(...) using the
same privilege keys used by other report pages (e.g., the pattern "REPORT_*" or
the specific privilege used for the comparable report page) so only authorized
users see/activate them; apply this to the Process button (action
bookKeepingSummery.createCashCategoryWithProDayDto), the Print (p:printer
target="panelPrint"), Excel (p:dataExporter target=...), and Compare
(action="report_cash_category_with_pro_day") controls, mirroring the existing
pages' use of webUserController.hasPrivilege() for rendered/disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves performance issues and timeouts in the By Category Day End Report by implementing DTO-based database queries instead of entity-based queries.
Closes #18380
Changes
CategoryDayEndReportDtoclass for optimized data transfercreateCashCategoryWithProDayDto()method inBookKeepingSummerycontroller with DTO-based query methodsreport_cash_category_with_pro_day_dto.xhtmlfor the optimized reportreport_own.xhtml) to access the new DTO-optimized reportTechnical Details
The DTO approach uses aggregated JPQL queries that:
SUM,COUNT,GROUP BYoperationsTesting
Files Changed
src/main/java/com/divudi/core/data/dto/CategoryDayEndReportDto.java(new)src/main/java/com/divudi/bean/report/BookKeepingSummery.java(modified)src/main/webapp/reportInstitution/report_cash_category_with_pro_day_dto.xhtml(new)src/main/webapp/reportInstitution/report_own.xhtml(modified)Related PRs
Summary by CodeRabbit