Skip to content

Added prod envs to restart scripts #11664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

ImeshRanawellaSG
Copy link
Collaborator

@ImeshRanawellaSG ImeshRanawellaSG commented Apr 8, 2025

Summary by CodeRabbit

  • New Features
    • Expanded the available servers for restart operations to include three additional options.
    • Introduced new workflow parameters that let users exclude specific servers during bulk operations.
    • Enhanced individual server selection with extra options for targeted actions.

@ImeshRanawellaSG ImeshRanawellaSG self-assigned this Apr 8, 2025
Copy link
Contributor

coderabbitai bot commented Apr 8, 2025

Walkthrough

The changes extend the server restart functionality by adding three new servers. The server restart script now includes additional entries in its server list. The GitHub Actions workflows have been updated with new boolean input options to exclude the new servers and with updated server selection options for individual server actions. The exclusion logic in the workflow and script has been adjusted to process the added server entries.

Changes

File(s) Change Summary
.github/scripts/restart_all_servers.sh Expanded INCLUDED_ARRAY to include three new servers: "Shared01(52.172.158.159)", "Shared02(20.204.129.229)", and "D01(4.213.180.217)".
.github/workflows/restart_all_servers.yml
.github/workflows/restart_individual_servers.yml
Added new input parameters (excludeShared01, excludeShared02, excludeD01) for exclusion in the all-servers workflow and new server options in the individual servers workflow.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant Workflow as GitHub Actions Workflow
    participant Script as restart_all_servers.sh

    User->>Workflow: Trigger workflow_dispatch with inputs
    Workflow->>Workflow: Evaluate exclusion flags (excludeDevelopment, excludeQA, excludeShared01, excludeShared02, excludeD01)
    Workflow->>Script: Call script with updated EXCLUDED_SERVERS
    Script->>Script: Filter INCLUDED_ARRAY based on exclusions
    Script->>User: Restart remaining servers
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a5b4e9 and 76cd72f.

📒 Files selected for processing (3)
  • .github/scripts/restart_all_servers.sh (1 hunks)
  • .github/workflows/restart_all_servers.yml (2 hunks)
  • .github/workflows/restart_individual_servers.yml (1 hunks)
🔇 Additional comments (4)
.github/workflows/restart_individual_servers.yml (1)

21-23: Expanded Server Options in Input List

The addition of the three new server options—Shared01(52.172.158.159), Shared02(20.204.129.229), and D01(4.213.180.217)—is clear and consistent with the new production environment requirements. This update ensures that users can now select these servers for individual operations.

.github/scripts/restart_all_servers.sh (1)

32-32: Updated Included Servers Array

The INCLUDED_ARRAY now includes the added servers "Shared01(52.172.158.159)", "Shared02(20.204.129.229)", and "D01(4.213.180.217)" alongside the original ones. This update is implemented correctly and ensures that the script processes the complete list of servers as intended.

.github/workflows/restart_all_servers.yml (2)

14-25: New Exclusion Input Parameters Added

The workflow now defines three additional boolean inputs—excludeShared01, excludeShared02, and excludeD01—with appropriate descriptions. This change enhances configurability by allowing users to exclude the new servers from operations when needed.


43-51: Extended Exclusion Logic for New Servers

The exclusion logic in the "Generate Excluded Servers List" step has been properly extended to include conditions for excludeShared01, excludeShared02, and excludeD01. This ensures that, when set to true, the corresponding server identifiers are appended to the EXCLUDED_SERVERS variable correctly.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ImeshRanawellaSG ImeshRanawellaSG merged commit fa0522d into development Apr 8, 2025
3 checks passed
@GSMgeeth GSMgeeth deleted the github-rules-for-prod-branches branch April 17, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants