Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove provider config from module #69

Merged
merged 21 commits into from
Sep 25, 2024
Merged

Remove provider config from module #69

merged 21 commits into from
Sep 25, 2024

Conversation

ieuanb74
Copy link
Contributor

@ieuanb74 ieuanb74 commented Sep 6, 2024

Jira link

https://tools.hmcts.net/jira/browse/DTSPO-18633

Change description

  • Remove provider config from module
  • Should be passed to the module by the consuming service, same as azurerm.cnp and azurerm.soc

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@Tyler-35 Tyler-35 mentioned this pull request Sep 11, 2024
Merged
MartyFox and others added 12 commits September 17, 2024 15:59
@danielwilsonkainos danielwilsonkainos merged commit 7058323 into master Sep 25, 2024
@ieuanb74 ieuanb74 mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ieuanb74 @danielwilsonkainos @MartyFox @JordanHoey96