-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix two text replacements in init script #556
Merged
Merged
Commits on Nov 30, 2023
-
Fix two text replacements in init script
There are two issues with the text replacements made by the init.sh script. These are: 1.) The packagesToScan property in application.yaml is changed from "uk.gov.hmcts.reform.demo.controllers" to "uk.gov.hmcts.reform.$component_name.controllers". It should be changed to "uk.gov.hmcts.reform.$package.controllers" to match the directory rename carried out later in the script. 2.) The chart name property in Chart.yaml is changed from "rpe-spring-boot-template" to "$product_name-$product_name-$component_name" by a combination of the maintainer name and slug replacements. It should be changed to "$product_name-$component_name". To fix the first issue the changes to the application.yaml file have been moved to a separate section. This replaces all instances of "rpe" with $product_name and then all instances of "reform.demo" with reform.$package". To fix the second issue a new line of code has been added to the section that processes the Chart.yaml file. This removes the "rpe-" prefix from the chart name value leaving just "spring-boot-template". The remaining "spring-boot-template" part is replaced with "$product_name-$component_name" when the slug replacement is carried out later in the script.
Configuration menu - View commit details
-
Copy full SHA for 2454acb - Browse repository at this point
Copy the full SHA 2454acbView commit details
Commits on Dec 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d186bbd - Browse repository at this point
Copy the full SHA d186bbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39a3d30 - Browse repository at this point
Copy the full SHA 39a3d30View commit details
Commits on Dec 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 385450a - Browse repository at this point
Copy the full SHA 385450aView commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 929d6c7 - Browse repository at this point
Copy the full SHA 929d6c7View commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c0b3abb - Browse repository at this point
Copy the full SHA c0b3abbView commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec08742 - Browse repository at this point
Copy the full SHA ec08742View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9ac7cfa - Browse repository at this point
Copy the full SHA 9ac7cfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19a4428 - Browse repository at this point
Copy the full SHA 19a4428View commit details
Commits on May 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd4cfa7 - Browse repository at this point
Copy the full SHA bd4cfa7View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ea2d1c - Browse repository at this point
Copy the full SHA 2ea2d1cView commit details
Commits on Jul 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8722b91 - Browse repository at this point
Copy the full SHA 8722b91View commit details
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dcfb17c - Browse repository at this point
Copy the full SHA dcfb17cView commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a0b78c0 - Browse repository at this point
Copy the full SHA a0b78c0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.