Update dependency pmd to v7 (#282)

* Update dependency pmd to v7 * Fix PMD problems --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael1142 <[email protected]>
hmcts · Aug 13, 2024 · e8cc39f · e8cc39f
1 parent 63e053a
commit e8cc39f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -42,7 +42,7 @@ checkstyle {
 }
 
 pmd {
-    toolVersion = "6.55.0"
+    toolVersion = "7.4.0"
     ignoreFailures = false
     sourceSets = [sourceSets.main, sourceSets.test, sourceSets.integrationTest]
     reportsDir = file("$project.buildDir/reports/pmd")

diff --git a/...uk/gov/hmcts/reform/authorisation/generators/AutorefreshingJwtAuthTokenGeneratorTest.java b/...uk/gov/hmcts/reform/authorisation/generators/AutorefreshingJwtAuthTokenGeneratorTest.java
@@ -57,7 +57,7 @@ public void should_not_request_new_token_if_cached_token_is_still_valid() throws
             .willReturn(jwtTokenWithExpDate(now().plus(2, HOURS)));
 
         // when
-        repeat(5, () -> jwtAuthTokenGenerator.generate());
+        repeat(5, jwtAuthTokenGenerator::generate);
 
         // then
         verify(generator, times(1)).generate();
@@ -70,7 +70,7 @@ public void should_request_new_token_once_it_expires() throws Exception {
             .willReturn(jwtTokenWithExpDate(now().minus(2, HOURS)));
 
         // when
-        repeat(3, () -> jwtAuthTokenGenerator.generate());
+        repeat(3, jwtAuthTokenGenerator::generate);
 
         // then
         verify(generator, times(3)).generate();
@@ -83,7 +83,7 @@ public void should_throw_an_exception_if_s2s_token_is_not_a_jwt_token() {
             .willReturn("clearly not a valid JWT token");
 
         // when
-        Throwable exc = catchThrowable(() -> jwtAuthTokenGenerator.generate());
+        Throwable exc = catchThrowable(jwtAuthTokenGenerator::generate);
 
         // then
         assertThat(exc)
@@ -112,7 +112,7 @@ public void should_request_a_new_token_if_delta_is_larger_than_time_left_to_expi
         verify(generator, times(2)).generate();
     }
 
-    private String jwtTokenWithExpDate(Instant expAtDate) throws Exception {
+    private String jwtTokenWithExpDate(Instant expAtDate) {
         return JWT
             .create()
             .withExpiresAt(Date.from(expAtDate))

diff --git a/...test/java/uk/gov/hmcts/reform/authorisation/generators/ServiceAuthTokenGeneratorTest.java b/...test/java/uk/gov/hmcts/reform/authorisation/generators/ServiceAuthTokenGeneratorTest.java
@@ -28,6 +28,6 @@ public void shouldGenerateServiceAuthToken() {
         final String result = serviceAuthTokenGenerator.generate();
 
         //then
-        assertThat(result).isNotNull().isEqualTo(serviceAuthToken);
+        assertThat(result).isEqualTo(serviceAuthToken);
     }
 }